Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Fix node example #234

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix node example #234

merged 1 commit into from
May 24, 2023

Conversation

jamesvclements
Copy link
Contributor

Description

I think the two readFile calls in the node example was a mistype, you only need one to pass the buffer and trying to call readFile on the result from the first call throws an error.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 1:51pm
example-with-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 1:51pm
example-with-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 1:51pm

@joe-bell
Copy link
Owner

You're absolutely right, thank you @jamesvclements!

@joe-bell joe-bell merged commit 4fa9526 into joe-bell:main May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants