-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The typings issue while upgrade to [email protected] #188
Comments
Adjust "splitChunks" config values. Upgrade html-webpack-plugin to v5 prerelease to silence deprecation warning. Upgrade terser-webpack-plugin to v5. Remove clean-webpack-plugin because not ready for v5. See johnagan/clean-webpack-plugin#182 and johnagan/clean-webpack-plugin#188.
Adjust "splitChunks" config values. Upgrade html-webpack-plugin to v5 prerelease to silence deprecation warning. Upgrade terser-webpack-plugin to v5. Remove clean-webpack-plugin because not ready for v5. See johnagan/clean-webpack-plugin#182 and johnagan/clean-webpack-plugin#188. Remove progress-bar-webpack-plugin because of weird v5 double completion. Remove chalk, only used by progress bar.
Is there any known workaround for this? For now I am removing clean-webpack-plugin from shared webpack configs in create-single-spa, since it throws typescript errors with webpack 5. |
@johnagan I am trying to update this package to webpack v5. But would like some help. See my branch: master...strootje:update-webpack-v5 It seems that the |
what progress about this issue |
You don't need this plugin with webpack v5, please look at |
@alexander-akait thanks for pointing this out! At the moment, Webpack 5 guides still recommend this plugin for cleaning the dist/ folder and a FYI there's a new, internal CleanPlugin Here's the relevant bit in the Webpack 5 src: https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L181-L186 |
That's great! I would be happy to deprecate this one since I don't have time to spend on it anymore. |
after we upgrade to webpack@5 it will throw typings errors
Maybe it should changed to
The text was updated successfully, but these errors were encountered: