Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct implementation of ndim ... #40

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Conversation

eserie
Copy link
Contributor

@eserie eserie commented Apr 21, 2021

... in order to work in compile mode with tensorflow (see issue tensorflow/tensorflow#48612 and #36)

TODO: add a specific test for the usage of tf.function?

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #40 (4bf7908) into master (4656839) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1753      1753           
=========================================
  Hits          1753      1753           
Impacted Files Coverage Δ
eagerpy/tensor/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4656839...4bf7908. Read the comment docs.

@jonasrauber
Copy link
Owner

Thanks!

If you want to add a specific test for the usage of tf.function (to ensure that feature changes stay compatible with tf.function), feel free to open another PR.

@eserie
Copy link
Contributor Author

eserie commented May 3, 2021

Thanks!

If you want to add a specific test for the usage of tf.function (to ensure that feature changes stay compatible with tf.function), feel free to open another PR.

Sure, I'll do so! I just have to think about how integrate such a specific test in the current test code base since currently it seems that we systematically test all backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants