Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cases of negative sentiment #133

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix cases of negative sentiment #133

merged 1 commit into from
Jan 20, 2023

Conversation

jonathanpeppers
Copy link
Owner

@jonathanpeppers jonathanpeppers commented Jan 20, 2023

Fixes: #131
Fixes: #132

I found usage of the word "account", "children", "dedicated" triggered negative sentiment. I split up some classifications that used this and added more examples.

I also changed where we classified "Close this PR", to "We can close this PR" as the second one sounds generally friendlier. I don't know if the first example should be underlined in all cases.

Fixes: #131
Fixes: #132

I found usage of the word "account", "children", "dedicated" triggered negative sentiment. I split up some classifications that used this and added more examples.

I also changed where we classified "Close this PR", to "We can close this PR" as the second one sounds generally friendlier. I don't know if the first example should be underlined in all cases.
@jonathanpeppers jonathanpeppers merged commit 86f22f5 into main Jan 20, 2023
@jonathanpeppers jonathanpeppers deleted the negative-sentiment branch January 20, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative sentiment Negative sentiment
1 participant