terraform issue jamesridgway/aws-lambda-short-url#3

jongwony · Aug 7, 2022 · a6e4d73 · a6e4d73
1 parent 90784b8
commit a6e4d73
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/infra/command_lambda.tf b/infra/command_lambda.tf
@@ -7,6 +7,10 @@ resource "aws_lambda_permission" "command_lambda_permission" {
   # The /*/*/* part allows invocation from any stage, method and resource path
   # within API Gateway REST API.
   source_arn = "${aws_api_gateway_rest_api.command_poll.execution_arn}/*/*/*"
+
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_lambda_function" "command_poll" {

diff --git a/infra/event_lambda.tf b/infra/event_lambda.tf
@@ -7,6 +7,10 @@ resource "aws_lambda_permission" "event_lambda_permission" {
   # The /*/*/* part allows invocation from any stage, method and resource path
   # within API Gateway REST API.
   source_arn = "${aws_api_gateway_rest_api.event_poll.execution_arn}/*/*/*"
+
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_api_gateway_rest_api" "event_poll" {

diff --git a/tests/test_event_poll.py b/tests/test_event_poll.py
@@ -8,8 +8,8 @@ def test_msg():
     body = {'token': 'FcLrpGmG3VeCuyd7bUMQszKz', 'team_id': 'T48RY2MFH', 'api_app_id': 'ABRRHSHHU',
             'event': {'client_msg_id': 'cf450427-50da-46cf-8f08-64d797000fe5', 'type': 'message', 'text': 'asdfasdf',
                       'user': 'U78RDCCJE', 'ts': '1585462244.003200', 'team': 'T48RY2MFH', 'blocks': [
-                    {'type': 'rich_text', 'block_id': 'uqCH',
-                     'elements': [{'type': 'rich_text_section', 'elements': [{'type': 'text', 'text': 'asdfasdf'}]}]}],
+                          {'type': 'rich_text', 'block_id': 'uqCH',
+                           'elements': [{'type': 'rich_text_section', 'elements': [{'type': 'text', 'text': 'asdfasdf'}]}]}],
                       'channel': 'CGK4QNXNC', 'event_ts': '1585462244.003200', 'channel_type': 'channel'},
             'type': 'event_callback', 'event_id': 'Ev0111FLKTFY', 'event_time': 1585462244, 'authed_users': ['UU42MN82Y']}
     event_message_changed.lambda_handler({'headers': {}, 'body': json.dumps(body)}, None)
@@ -44,24 +44,24 @@ def dummy_func(*args, **kwargs):
                       'message': {'client_msg_id': 'd1921061-3cbe-42c0-8ce6-92ca8c393874', 'type': 'message',
                                   'text': '<https://mingrammer.com/translation-asynchronous-python/>', 'user': 'U78RDCCJE',
                                   'team': 'T48RY2MFH', 'attachments': [
-                              {'title': '[번역] 비동기 파이썬', 'title_link': 'https://mingrammer.com/translation-asynchronous-python/',
-                               'text': 'Asynchronous Python을 번역한 글입니다. 파이썬에서의 비동기 프로그래밍은 최근 점점 더 많은 인기를 끌고있다. 비동기 프로그래밍을 위한 파이썬 라이브러리는 많다. 그',
-                               'fallback': '[번역] 비동기 파이썬', 'ts': 1475452800,
-                               'from_url': 'https://mingrammer.com/translation-asynchronous-python/',
-                               'service_icon': 'https://mingrammer.com/images/favicon.ico', 'service_name': 'mingrammer.com',
-                               'id': 1, 'original_url': 'https://mingrammer.com/translation-asynchronous-python/'}], 'blocks': [
-                              {'type': 'rich_text', 'block_id': 'wQ8n', 'elements': [{'type': 'rich_text_section', 'elements': [
-                                  {'type': 'link', 'url': 'https://mingrammer.com/translation-asynchronous-python/'}]}]}],
+                                      {'title': '[번역] 비동기 파이썬', 'title_link': 'https://mingrammer.com/translation-asynchronous-python/',
+                                       'text': 'Asynchronous Python을 번역한 글입니다. 파이썬에서의 비동기 프로그래밍은 최근 점점 더 많은 인기를 끌고있다. 비동기 프로그래밍을 위한 파이썬 라이브러리는 많다. 그',
+                                       'fallback': '[번역] 비동기 파이썬', 'ts': 1475452800,
+                                       'from_url': 'https://mingrammer.com/translation-asynchronous-python/',
+                                       'service_icon': 'https://mingrammer.com/images/favicon.ico', 'service_name': 'mingrammer.com',
+                                       'id': 1, 'original_url': 'https://mingrammer.com/translation-asynchronous-python/'}], 'blocks': [
+                                      {'type': 'rich_text', 'block_id': 'wQ8n', 'elements': [{'type': 'rich_text_section', 'elements': [
+                                          {'type': 'link', 'url': 'https://mingrammer.com/translation-asynchronous-python/'}]}]}],
                                   'ts': '1585461761.002500'}, 'channel': 'CGK4QNXNC',
                       'previous_message': {'client_msg_id': 'd1921061-3cbe-42c0-8ce6-92ca8c393874', 'type': 'message',
                                            'text': '<https://mingrammer.com/translation-asynchronous-python/>',
                                            'user': 'U78RDCCJE', 'ts': '1585461761.002500', 'team': 'T48RY2MFH', 'blocks': [
-                              {'type': 'rich_text', 'block_id': 'wQ8n', 'elements': [{'type': 'rich_text_section', 'elements': [
-                                  {'type': 'link', 'url': 'https://mingrammer.com/translation-asynchronous-python/'}]}]}]},
+                                               {'type': 'rich_text', 'block_id': 'wQ8n', 'elements': [{'type': 'rich_text_section', 'elements': [
+                                                   {'type': 'link', 'url': 'https://mingrammer.com/translation-asynchronous-python/'}]}]}]},
                       'event_ts': '1585461762.002600', 'ts': '1585461762.002600', 'channel_type': 'channel'},
             'type': 'event_callback', 'event_id': 'Ev0111FHUP4N', 'event_time': 1585461762, 'authed_users': ['UU42MN82Y']}
     event_message_changed.lambda_handler({'headers': body, 'body': json.dumps(body)}, None)
 
 
 def test_params():
-    events = {'resource': '/event_poll', 'path': '/event_poll', 'httpMethod': 'POST', 'headers': {'Accept': '*/*', 'Accept-Encoding': 'gzip,deflate', 'CloudFront-Forwarded-Proto': 'https', 'CloudFront-Is-Desktop-Viewer': 'true', 'CloudFront-Is-Mobile-Viewer': 'false', 'CloudFront-Is-SmartTV-Viewer': 'false', 'CloudFront-Is-Tablet-Viewer': 'false', 'CloudFront-Viewer-Country': 'US', 'Content-Type': 'application/json', 'Host': 'xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com', 'User-Agent': 'Slackbot 1.0 (+https://api.slack.com/robots)', 'Via': '1.1 841dfa6074cf4b3b0718988f088a4ac2.cloudfront.net (CloudFront)', 'X-Amz-Cf-Id': 'P7mTocVUom0_LVujFTb8dulOfJpzBDxmF4zYPBh-6Z0te_QwZFXAjA==', 'X-Amzn-Trace-Id': 'Root=1-5e80ded1-2cf5b0b4fbf8431eb3614baa', 'X-Forwarded-For': '3.86.97.99, 70.132.33.131', 'X-Forwarded-Port': '443', 'X-Forwarded-Proto': 'https', 'X-Slack-Request-Timestamp': '1585503952', 'X-Slack-Signature': 'v0=2cab3fe8491a64edd51252868b7f12e5657ebd5120530980f0f53fa7097a3e1c'}, 'multiValueHeaders': {'Accept': ['*/*'], 'Accept-Encoding': ['gzip,deflate'], 'CloudFront-Forwarded-Proto': ['https'], 'CloudFront-Is-Desktop-Viewer': ['true'], 'CloudFront-Is-Mobile-Viewer': ['false'], 'CloudFront-Is-SmartTV-Viewer': ['false'], 'CloudFront-Is-Tablet-Viewer': ['false'], 'CloudFront-Viewer-Country': ['US'], 'Content-Type': ['application/json'], 'Host': ['xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com'], 'User-Agent': ['Slackbot 1.0 (+https://api.slack.com/robots)'], 'Via': ['1.1 841dfa6074cf4b3b0718988f088a4ac2.cloudfront.net (CloudFront)'], 'X-Amz-Cf-Id': ['P7mTocVUom0_LVujFTb8dulOfJpzBDxmF4zYPBh-6Z0te_QwZFXAjA=='], 'X-Amzn-Trace-Id': ['Root=1-5e80ded1-2cf5b0b4fbf8431eb3614baa'], 'X-Forwarded-For': ['3.86.97.99, 70.132.33.131'], 'X-Forwarded-Port': ['443'], 'X-Forwarded-Proto': ['https'], 'X-Slack-Request-Timestamp': ['1585503952'], 'X-Slack-Signature': ['v0=2cab3fe8491a64edd51252868b7f12e5657ebd5120530980f0f53fa7097a3e1c']}, 'queryStringParameters': None, 'multiValueQueryStringParameters': None, 'pathParameters': None, 'stageVariables': None, 'requestContext': {'resourceId': '6ygwe7', 'resourcePath': '/event_poll', 'httpMethod': 'POST', 'extendedRequestId': 'KKfAuEVWoE0FrCQ=', 'requestTime': '29/Mar/2020:17:45:53 +0000', 'path': '/default/event_poll', 'accountId': '237943334087', 'protocol': 'HTTP/1.1', 'stage': 'default', 'domainPrefix': 'xvyryyt8fk', 'requestTimeEpoch': 1585503953364, 'requestId': 'aa6b9193-b9fb-443b-97d6-a09c4dfc6f59', 'identity': {'cognitoIdentityPoolId': None, 'accountId': None, 'cognitoIdentityId': None, 'caller': None, 'sourceIp': '3.86.97.99', 'principalOrgId': None, 'accessKey': None, 'cognitoAuthenticationType': None, 'cognitoAuthenticationProvider': None, 'userArn': None, 'userAgent': 'Slackbot 1.0 (+https://api.slack.com/robots)', 'user': None}, 'domainName': 'xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com', 'apiId': 'xvyryyt8fk'}, 'body': '{"token":"FcLrpGmG3VeCuyd7bUMQszKz","team_id":"T48RY2MFH","api_app_id":"ABRRHSHHU","event":{"type":"message","subtype":"message_changed","hidden":true,"message":{"client_msg_id":"a3f958ee-e984-4dca-b3d9-4518cbc67e19","type":"message","text":"<https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics>","user":"U78RDCCJE","team":"T48RY2MFH","attachments":[{"service_name":"Slack","title":"Creating rich message layouts","title_link":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics","text":"Learn how to build bot users, send notifications, and interact with workspaces using our APIs.","fallback":"Slack: Creating rich message layouts","thumb_url":"https:\\/\\/a.slack-edge.com\\/80588\\/img\\/services\\/api_200.png","from_url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics","thumb_width":200,"thumb_height":200,"service_icon":"https:\\/\\/a.slack-edge.com\\/80588\\/marketing\\/img\\/meta\\/favicon-32.png","id":1,"original_url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}],"blocks":[{"type":"rich_text","block_id":"xLVQ","elements":[{"type":"rich_text_section","elements":[{"type":"link","url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}]}]}],"ts":"1585503951.004300"},"channel":"CGK4QNXNC","previous_message":{"client_msg_id":"a3f958ee-e984-4dca-b3d9-4518cbc67e19","type":"message","text":"<https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics>","user":"U78RDCCJE","ts":"1585503951.004300","team":"T48RY2MFH","blocks":[{"type":"rich_text","block_id":"xLVQ","elements":[{"type":"rich_text_section","elements":[{"type":"link","url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}]}]}]},"event_ts":"1585503952.004400","ts":"1585503952.004400","channel_type":"channel"},"type":"event_callback","event_id":"Ev010ZEST3NG","event_time":1585503952,"authed_users":["UU42MN82Y"]}', 'isBase64Encoded': False}
+    events = {'resource': '/event_poll', 'path': '/event_poll', 'httpMethod': 'POST', 'headers': {'Accept': '*/*', 'Accept-Encoding': 'gzip,deflate', 'CloudFront-Forwarded-Proto': 'https', 'CloudFront-Is-Desktop-Viewer': 'true', 'CloudFront-Is-Mobile-Viewer': 'false', 'CloudFront-Is-SmartTV-Viewer': 'false', 'CloudFront-Is-Tablet-Viewer': 'false', 'CloudFront-Viewer-Country': 'US', 'Content-Type': 'application/json', 'Host': 'xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com', 'User-Agent': 'Slackbot 1.0 (+https://api.slack.com/robots)', 'Via': '1.1 841dfa6074cf4b3b0718988f088a4ac2.cloudfront.net (CloudFront)', 'X-Amz-Cf-Id': 'P7mTocVUom0_LVujFTb8dulOfJpzBDxmF4zYPBh-6Z0te_QwZFXAjA==', 'X-Amzn-Trace-Id': 'Root=1-5e80ded1-2cf5b0b4fbf8431eb3614baa', 'X-Forwarded-For': '3.86.97.99, 70.132.33.131', 'X-Forwarded-Port': '443', 'X-Forwarded-Proto': 'https', 'X-Slack-Request-Timestamp': '1585503952', 'X-Slack-Signature': 'v0=2cab3fe8491a64edd51252868b7f12e5657ebd5120530980f0f53fa7097a3e1c'}, 'multiValueHeaders': {'Accept': ['*/*'], 'Accept-Encoding': ['gzip,deflate'], 'CloudFront-Forwarded-Proto': ['https'], 'CloudFront-Is-Desktop-Viewer': ['true'], 'CloudFront-Is-Mobile-Viewer': ['false'], 'CloudFront-Is-SmartTV-Viewer': ['false'], 'CloudFront-Is-Tablet-Viewer': ['false'], 'CloudFront-Viewer-Country': ['US'], 'Content-Type': ['application/json'], 'Host': ['xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com'], 'User-Agent': ['Slackbot 1.0 (+https://api.slack.com/robots)'], 'Via': ['1.1 841dfa6074cf4b3b0718988f088a4ac2.cloudfront.net (CloudFront)'], 'X-Amz-Cf-Id': ['P7mTocVUom0_LVujFTb8dulOfJpzBDxmF4zYPBh-6Z0te_QwZFXAjA=='], 'X-Amzn-Trace-Id': ['Root=1-5e80ded1-2cf5b0b4fbf8431eb3614baa'], 'X-Forwarded-For': ['3.86.97.99, 70.132.33.131'], 'X-Forwarded-Port': ['443'], 'X-Forwarded-Proto': ['https'], 'X-Slack-Request-Timestamp': ['1585503952'], 'X-Slack-Signature': ['v0=2cab3fe8491a64edd51252868b7f12e5657ebd5120530980f0f53fa7097a3e1c']}, 'queryStringParameters': None, 'multiValueQueryStringParameters': None, 'pathParameters': None, 'stageVariables': None, 'requestContext': {'resourceId': '6ygwe7', 'resourcePath': '/event_poll', 'httpMethod': 'POST', 'extendedRequestId': 'KKfAuEVWoE0FrCQ=', 'requestTime': '29/Mar/2020:17:45:53 +0000', 'path': '/default/event_poll', 'accountId': '237943334087', 'protocol': 'HTTP/1.1', 'stage': 'default', 'domainPrefix': 'xvyryyt8fk', 'requestTimeEpoch': 1585503953364, 'requestId': 'aa6b9193-b9fb-443b-97d6-a09c4dfc6f59', 'identity': {'cognitoIdentityPoolId': None, 'accountId': None, 'cognitoIdentityId': None, 'caller': None, 'sourceIp': '3.86.97.99', 'principalOrgId': None, 'accessKey': None, 'cognitoAuthenticationType': None, 'cognitoAuthenticationProvider': None, 'userArn': None, 'userAgent': 'Slackbot 1.0 (+https://api.slack.com/robots)', 'user': None}, 'domainName': 'xvyryyt8fk.execute-api.ap-northeast-2.amazonaws.com', 'apiId': 'xvyryyt8fk'}, 'body': '{"token":"FcLrpGmG3VeCuyd7bUMQszKz","team_id":"T48RY2MFH","api_app_id":"ABRRHSHHU","event":{"type":"message","subtype":"message_changed","hidden":true,"message":{"client_msg_id":"a3f958ee-e984-4dca-b3d9-4518cbc67e19","type":"message","text":"<https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics>","user":"U78RDCCJE","team":"T48RY2MFH","attachments":[{"service_name":"Slack","title":"Creating rich message layouts","title_link":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics","text":"Learn how to build bot users, send notifications, and interact with workspaces using our APIs.","fallback":"Slack: Creating rich message layouts","thumb_url":"https:\\/\\/a.slack-edge.com\\/80588\\/img\\/services\\/api_200.png","from_url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics","thumb_width":200,"thumb_height":200,"service_icon":"https:\\/\\/a.slack-edge.com\\/80588\\/marketing\\/img\\/meta\\/favicon-32.png","id":1,"original_url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}],"blocks":[{"type":"rich_text","block_id":"xLVQ","elements":[{"type":"rich_text_section","elements":[{"type":"link","url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}]}]}],"ts":"1585503951.004300"},"channel":"CGK4QNXNC","previous_message":{"client_msg_id":"a3f958ee-e984-4dca-b3d9-4518cbc67e19","type":"message","text":"<https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics>","user":"U78RDCCJE","ts":"1585503951.004300","team":"T48RY2MFH","blocks":[{"type":"rich_text","block_id":"xLVQ","elements":[{"type":"rich_text_section","elements":[{"type":"link","url":"https:\\/\\/api.slack.com\\/messaging\\/composing\\/layouts#block-basics"}]}]}]},"event_ts":"1585503952.004400","ts":"1585503952.004400","channel_type":"channel"},"type":"event_callback","event_id":"Ev010ZEST3NG","event_time":1585503952,"authed_users":["UU42MN82Y"]}', 'isBase64Encoded': False}