add append, appendString, and appendBuffer methods (closes #1) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed the |
I think some of the |
jonschlinkert
changed the title
|
@doowb feel free to merge and publish when you think it's ready, thanks! |
doowb
added a commit
to doowb/append-string
that referenced
this pull request
Aug 1, 2017
- bring in code from file-normalize (original introduced in PR jonschlinkert/file-normalize#3) - add tests
doowb
added a commit
to doowb/append-buffer
that referenced
this pull request
Aug 1, 2017
- bring in code from file-normalize (original introduced in PR jonschlinkert/file-normalize#3) - add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
append,appendString, andappendBuffermethods discussed in #1.Adds unit tests for scenarios discussed.
Doing the PR against the dev branch since that already has a PR to master.