Implemented a few KeyBindings #40
jortrrAnnotations
1 error and 31 warnings
|
benchmark
No benchmark result was found in /home/runner/work/mandelbrot/mandelbrot/output.txt. Benchmark output was ''
|
|
this function has too many lines (106/100):
src/lib.rs#L356
warning: this function has too many lines (106/100)
--> src/lib.rs:356:1
|
356 | / pub fn run() -> Result<(), Box<dyn Error>> {
357 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
358 | | //Coloring function
359 | | let mut coloring_function = COLORING_FUNCTION;
... |
481 | | Ok(())
482 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
|
|
adding items after statements is confusing, since items exist from the start of the scope:
src/lib.rs#L305
warning: adding items after statements is confusing, since items exist from the start of the scope
--> src/lib.rs:305:5
|
305 | static RIGHT_MOUSE_RECORDER: MouseClickRecorder = MouseClickRecorder::new(MouseButton::Right);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
|
|
adding items after statements is confusing, since items exist from the start of the scope:
src/lib.rs#L304
warning: adding items after statements is confusing, since items exist from the start of the scope
--> src/lib.rs:304:5
|
304 | static LEFT_MOUSE_RECORDER: MouseClickRecorder = MouseClickRecorder::new(MouseButton::Left); //Static variable with interior mutabili...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
= note: `#[warn(clippy::items_after_statements)]` implied by `#[warn(clippy::pedantic)]`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L296
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:296:13
|
296 | self.previous.store(current, Ordering::Relaxed)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.previous.store(current, Ordering::Relaxed);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L218
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:218:17
|
218 | println!("translation_amount: {}", mandelbrot_model.vars.translation_amount)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `println!("translation_amount: {}", mandelbrot_model.vars.translation_amount);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L203
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:203:17
|
203 | / *coloring_function = pick_option(&[
204 | | ("HSV", TrueColor::new_from_hsv_colors),
205 | | ("Bernstein polynomials", TrueColor::new_from_bernstein_polynomials),
206 | | ])
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
help: add a `;` here
|
203 ~ *coloring_function = pick_option(&[
204 + ("HSV", TrueColor::new_from_hsv_colors),
205 + ("Bernstein polynomials", TrueColor::new_from_bernstein_polynomials),
206 + ]);
|
|
|
strict comparison of `f32` or `f64`:
src/lib.rs#L176
warning: strict comparison of `f32` or `f64`
--> src/lib.rs:176:20
|
176 | if mandelbrot_model.config.window_scale == 1.0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(mandelbrot_model.config.window_scale - 1.0).abs() < error_margin`
|
= note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
= note: `#[warn(clippy::float_cmp)]` implied by `#[warn(clippy::pedantic)]`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L166
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:166:17
|
166 | mandelbrot_model.c.scale(inverse_scaling_factor)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `mandelbrot_model.c.scale(inverse_scaling_factor);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L162
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:162:17
|
162 | mandelbrot_model.c.scale(scaling_factor)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `mandelbrot_model.c.scale(scaling_factor);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L153
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:153:17
|
153 | rendering::translate_and_render_efficiently(&mut mandelbrot_model, 0, columns, *coloring_function)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `rendering::translate_and_render_efficiently(&mut mandelbrot_model, 0, columns, *coloring_function);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L149
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:149:17
|
149 | rendering::translate_and_render_efficiently(&mut mandelbrot_model, 0, columns, *coloring_function)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `rendering::translate_and_render_efficiently(&mut mandelbrot_model, 0, columns, *coloring_function);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L145
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:145:17
|
145 | rendering::translate_and_render_efficiently(&mut mandelbrot_model, rows, 0, *coloring_function)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `rendering::translate_and_render_efficiently(&mut mandelbrot_model, rows, 0, *coloring_function);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L141
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:141:17
|
141 | rendering::translate_and_render_efficiently(&mut mandelbrot_model, rows.into(), 0, *coloring_function)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `rendering::translate_and_render_efficiently(&mut mandelbrot_model, rows.into(), 0, *coloring_function);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
= note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`
|
|
this function has too many lines (116/100):
src/lib.rs#L132
warning: this function has too many lines (116/100)
--> src/lib.rs:132:1
|
132 | / fn handle_key_events(window: &Window, k: &KeyBindings, coloring_function: &mut ColoringFunction) {
133 | | if let Some(key) = window.get_keys_pressed(minifb::KeyRepeat::No).first() {
134 | | print!("\nKey pressed: ");
135 | | k.print_key(key);
... |
248 | | }
249 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
= note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function which may panic missing `# Panics` section:
src/view/coloring.rs#L123
warning: docs for function which may panic missing `# Panics` section
--> src/view/coloring.rs:123:5
|
123 | pub fn get_color(&self, color: char) -> u8 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/view/coloring.rs:124:9
|
124 | / assert!(
125 | | color == 'R' || color == 'G' || color == 'B',
126 | | "Error: color should be equal to R, G, or B, color = {}",
127 | | color
128 | | );
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
docs for function returning `Result` missing `# Errors` section:
src/view/coloring.rs#L43
warning: docs for function returning `Result` missing `# Errors` section
--> src/view/coloring.rs:43:5
|
43 | pub fn new(r_g_b: &str) -> Result<ColorChannelMapping, String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
item in documentation is missing backticks:
src/view/coloring.rs#L10
warning: item in documentation is missing backticks
--> src/view/coloring.rs:10:10
|
10 | /// E.g: Ok(ColorChannelMapping::BGR) means that red will get the value of blue, green the value of green, and blue the value of red:
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
10 | /// E.g: `Ok(ColorChannelMapping::BGR`) means that red will get the value of blue, green the value of green, and blue the value of red:
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
item in documentation is missing backticks:
src/view/coloring.rs#L8
warning: item in documentation is missing backticks
--> src/view/coloring.rs:8:19
|
8 | ///A mapping from ColorChannelMapping -> RGB, the first character denotes the new red channel, the second character the new green channel,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
8 | ///A mapping from `ColorChannelMapping` -> RGB, the first character denotes the new red channel, the second character the new green channel,
| ~~~~~~~~~~~~~~~~~~~~~
|
|
the function has a cognitive complexity of (7/5):
src/model/rendering.rs#L108
warning: the function has a cognitive complexity of (7/5)
--> src/model/rendering.rs:108:41
|
108 | let handle = thread::spawn(move || {
| ^^
|
= help: you could split it up into multiple smaller functions
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cognitive_complexity
= note: `#[warn(clippy::cognitive_complexity)]` implied by `#[warn(clippy::nursery)]`
|
|
temporary with significant `Drop` can be early dropped:
src/model/mandelbrot_model.rs#L42
warning: temporary with significant `Drop` can be early dropped
--> src/model/mandelbrot_model.rs:42:13
|
41 | pub fn get_instance() -> MutexGuard<'static, MandelbrotModel> {
| ___________________________________________________________________-
42 | | let lock = MANDELBROT_MODEL_INSTANCE.try_lock();
| | ^^^^
43 | | if let Ok(instance) = lock {
44 | | return instance;
45 | | }
46 | | panic!("You have called the singleton twice! This should never happen. It means that within the same scope, MandelbrotModel::get_...
47 | | }
| |_____- temporary `lock` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
note: the lint level is defined here
--> src/lib.rs:4:5
|
4 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::significant_drop_tightening)]` implied by `#[warn(clippy::nursery)]`
help: merge the temporary construction with its single usage
|
42 ~
43 + MANDELBROT_MODEL_INSTANCE.try_lock().;
|
help: remove separated single usage
|
43 - if let Ok(instance) = lock {
44 - return instance;
45 - }
43 +
|
|
|
docs for function which may panic missing `# Panics` section:
src/model/mandelbrot_model.rs#L41
warning: docs for function which may panic missing `# Panics` section
--> src/model/mandelbrot_model.rs:41:5
|
41 | pub fn get_instance() -> MutexGuard<'static, MandelbrotModel> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/model/mandelbrot_model.rs:46:9
|
46 | ... panic!("You have called the singleton twice! This should never happen. It means that within the same scope, MandelbrotModel::get_instance() was called more than once....
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
item in documentation is missing backticks:
src/model/mandelbrot_model.rs#L40
warning: item in documentation is missing backticks
--> src/model/mandelbrot_model.rs:40:31
|
40 | /// Returns the singleton MandelbrotModel instance.
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
|
40 | /// Returns the singleton `MandelbrotModel` instance.
| ~~~~~~~~~~~~~~~~~
|
|
using `clone` on type `Config` which implements the `Copy` trait:
src/model/mandelbrot_model.rs#L31
warning: using `clone` on type `Config` which implements the `Copy` trait
--> src/model/mandelbrot_model.rs:31:21
|
31 | config: config.clone(),
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
note: the lint level is defined here
--> src/lib.rs:9:5
|
9 | clippy::complexity
| ^^^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::clone_on_copy)]` implied by `#[warn(clippy::complexity)]`
|
|
you should consider adding a `Default` implementation for `MandelbrotModel`:
src/model/mandelbrot_model.rs#L25
warning: you should consider adding a `Default` implementation for `MandelbrotModel`
--> src/model/mandelbrot_model.rs:25:5
|
25 | / pub fn new() -> MandelbrotModel {
26 | | let config = Config::build(env::args()).unwrap_or_else(|err| {
27 | | eprintln!("Problem parsing arguments: {}", err);
28 | | process::exit(1);
... |
37 | | }
38 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
24 + impl Default for MandelbrotModel {
25 + fn default() -> Self {
26 + Self::new()
27 + }
28 + }
|
|
|
docs for function which may panic missing `# Panics` section:
src/controller/user_input.rs#L31
warning: docs for function which may panic missing `# Panics` section
--> src/controller/user_input.rs:31:1
|
31 | pub fn get_user_input_untrimmed() -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/controller/user_input.rs:34:5
|
34 | / io::stdin()
35 | | .read_line(&mut user_input)
36 | | .expect("Error: Failed to read the user's input from stdin.");
| |_____________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> src/lib.rs:3:5
|
3 | clippy::pedantic,
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
you should consider adding a `Default` implementation for `Config`:
src/controller/config.rs#L32
warning: you should consider adding a `Default` implementation for `Config`
--> src/controller/config.rs:32:5
|
32 | / pub fn new() -> Config {
33 | | Config {
34 | | window_width: WIDTH,
35 | | window_height: HEIGHT,
... |
42 | | }
43 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
note: the lint level is defined here
--> src/lib.rs:2:5
|
2 | clippy::all,
| ^^^^^^^^^^^
= note: `#[warn(clippy::new_without_default)]` implied by `#[warn(clippy::all)]`
help: try adding this
|
31 + impl Default for Config {
32 + fn default() -> Self {
33 + Self::new()
34 + }
35 + }
|
|
|
static `COLOR_CHANNEL_MAPPING` is never used:
src/lib.rs#L56
warning: static `COLOR_CHANNEL_MAPPING` is never used
--> src/lib.rs:56:8
|
56 | static COLOR_CHANNEL_MAPPING: ColorChannelMapping = ColorChannelMapping::RGB;
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `mandelbrot_model`:
src/lib.rs#L45
warning: unused import: `mandelbrot_model`
--> src/lib.rs:45:13
|
45 | use model::{mandelbrot_model, pixel_buffer, pixel_plane, rendering};
| ^^^^^^^^^^^^^^^^
|
|
unused import: `model::mandelbrot_function::MandelbrotFunction`:
src/lib.rs#L43
warning: unused import: `model::mandelbrot_function::MandelbrotFunction`
--> src/lib.rs:43:5
|
43 | use model::mandelbrot_function::MandelbrotFunction;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
benchmark
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|