Added coloring_function to MandelbrotModel #42
Annotations
1 error and 39 warnings
benchmark
No benchmark result was found in /home/runner/work/mandelbrot/mandelbrot/output.txt. Benchmark output was ''
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L513
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:513:9
|
513 | println!("Window closed, application exited gracefully.")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `println!("Window closed, application exited gracefully.");`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L457
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:457:21
|
456 | || {
| ____________-
457 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
458 | | mandelbrot_model.config.supersampling_amount = ask::<u8>("supersampling_amount").clamp(1, 64);
459 | | render(&mut mandelbrot_model);
460 | | },
| |_________- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
457 ~
458 + MandelbrotModel::get_instance().;
|
help: remove separated single usage
|
458 - mandelbrot_model.config.supersampling_amount = ask::<u8>("supersampling_amount").clamp(1, 64);
458 +
|
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L448
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:448:21
|
447 | || {
| ____________-
448 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
449 | | mandelbrot_model.p.color_channel_mapping = ask("color_channel_mapping");
450 | | render(&mut mandelbrot_model);
451 | | },
| |_________- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
448 ~
449 + MandelbrotModel::get_instance().;
|
help: remove separated single usage
|
449 - mandelbrot_model.p.color_channel_mapping = ask("color_channel_mapping");
449 +
|
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L440
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:440:17
|
439 | key_bindings.add(Key::M, "Change the Mandelbrot set view max_iterations", || {
| __________________________________________________________________________________-
440 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
441 | | mandelbrot_model.m.max_iterations = ask("max_iterations");
442 | | render(&mut mandelbrot_model);
443 | | });
| |_____- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
440 ~
441 + MandelbrotModel::get_instance().;
|
help: remove separated single usage
|
441 - mandelbrot_model.m.max_iterations = ask("max_iterations");
441 +
|
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L434
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:434:17
|
433 | key_bindings.add(Key::I, "Manually input a Mandelbrot set view", || {
| _________________________________________________________________________-
434 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
435 | | mandelbrot_model.c.set_view(&View::new(ask("x"), ask("y"), ask("scale")));
436 | | render(&mut mandelbrot_model);
437 | | });
| |_____- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
434 ~
435 + MandelbrotModel::get_instance().set_view(&View::new(ask("x"), ask("y"), ask("scale")));
|
help: remove separated single usage
|
435 - mandelbrot_model.c.set_view(&View::new(ask("x"), ask("y"), ask("scale")));
435 +
|
|
strict comparison of `f32` or `f64`:
src/lib.rs#L407
warning: strict comparison of `f32` or `f64`
--> src/lib.rs:407:16
|
407 | if mandelbrot_model.config.window_scale == 1.0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(mandelbrot_model.config.window_scale - 1.0).abs() < error_margin`
|
= note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
= note: `#[warn(clippy::float_cmp)]` implied by `#[warn(clippy::pedantic)]`
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L398
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:398:9
|
398 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_0)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_0);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L395
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:395:9
|
395 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_9)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_9);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L392
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:392:9
|
392 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_8)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_8);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L389
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:389:9
|
389 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_7)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_7);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L386
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:386:9
|
386 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_6)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_6);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L383
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:383:9
|
383 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_5)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_5);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L380
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:380:9
|
380 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_4)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_4);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L377
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:377:9
|
377 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_3)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_3);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L374
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:374:9
|
374 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_2)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_2);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L371
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:371:9
|
371 | set_view(&mut MandelbrotModel::get_instance(), &VIEW_1)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `set_view(&mut MandelbrotModel::get_instance(), &VIEW_1);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L356
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:356:21
|
355 | || {
| ____________-
356 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
357 | | let inverse_scaling_factor = mandelbrot_model.vars.inverse_scaling_factor();
358 | | mandelbrot_model.c.scale(inverse_scaling_factor);
359 | | render(&mut mandelbrot_model);
360 | | },
| |_________- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: drop the temporary after the end of its last usage
|
358 ~ mandelbrot_model.c.scale(inverse_scaling_factor);
359 + drop(mandelbrot_model);
|
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L347
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:347:17
|
346 | key_bindings.add(Key::LeftBracket, "Scale the view by scaling_factor, effectively zooming in", || {
| _______________________________________________________________________________________________________-
347 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
348 | | let scaling_factor = mandelbrot_model.vars.scaling_factor();
349 | | mandelbrot_model.c.scale(scaling_factor);
350 | | render(&mut mandelbrot_model);
351 | | });
| |_____- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: drop the temporary after the end of its last usage
|
349 ~ mandelbrot_model.c.scale(scaling_factor);
350 + drop(mandelbrot_model);
|
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L315
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:315:17
|
314 | key_bindings.add(Key::R, "Reset the Mandelbrot set view to the starting view", || {
| _______________________________________________________________________________________-
315 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
316 | | mandelbrot_model.c.reset();
317 | | render(&mut mandelbrot_model);
318 | | });
| |_____- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
315 ~
316 + MandelbrotModel::get_instance().reset();
|
help: remove separated single usage
|
316 - mandelbrot_model.c.reset();
316 +
|
|
this function has too many lines (232/100):
src/lib.rs#L267
warning: this function has too many lines (232/100)
--> src/lib.rs:267:1
|
267 | / pub fn run() -> Result<(), Box<dyn Error>> {
268 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
269 | | //Coloring function
270 | | mandelbrot_model.coloring_function = COLORING_FUNCTION;
... |
515 | | Ok(())
516 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
= note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
|
adding items after statements is confusing, since items exist from the start of the scope:
src/lib.rs#L205
warning: adding items after statements is confusing, since items exist from the start of the scope
--> src/lib.rs:205:5
|
205 | static RIGHT_MOUSE_RECORDER: MouseClickRecorder = MouseClickRecorder::new(MouseButton::Right);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
|
adding items after statements is confusing, since items exist from the start of the scope:
src/lib.rs#L204
warning: adding items after statements is confusing, since items exist from the start of the scope
--> src/lib.rs:204:5
|
204 | static LEFT_MOUSE_RECORDER: MouseClickRecorder = MouseClickRecorder::new(MouseButton::Left); //Static variable with interior mutabili...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
= note: `#[warn(clippy::items_after_statements)]` implied by `#[warn(clippy::pedantic)]`
|
consider adding a `;` to the last statement for consistent formatting:
src/lib.rs#L196
warning: consider adding a `;` to the last statement for consistent formatting
--> src/lib.rs:196:13
|
196 | self.previous.store(current, Ordering::Relaxed)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.previous.store(current, Ordering::Relaxed);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
= note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`
|
temporary with significant `Drop` can be early dropped:
src/lib.rs#L136
warning: temporary with significant `Drop` can be early dropped
--> src/lib.rs:136:17
|
132 | if let Some(key) = window.get_keys_pressed(minifb::KeyRepeat::No).first() {
| _______________________________________________________________________________-
133 | | print!("\nKey pressed: ");
134 | | k.print_key(key);
135 | | k.run(key);
136 | | let mut mandelbrot_model = MandelbrotModel::get_instance();
| | ^^^^^^^^^^^^^^^^
... |
147 | | }
148 | | }
| |_____- temporary `mandelbrot_model` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
help: merge the temporary construction with its single usage
|
136 ~
137 + MandelbrotModel::get_instance().;
|
help: remove separated single usage
|
140 - mandelbrot_model.coloring_function = pick_option(&[
141 - ("HSV", TrueColor::new_from_hsv_colors),
142 - ("Bernstein polynomials", TrueColor::new_from_bernstein_polynomials),
143 - ]);
140 +
|
|
docs for function which may panic missing `# Panics` section:
src/view/coloring.rs#L123
warning: docs for function which may panic missing `# Panics` section
--> src/view/coloring.rs:123:5
|
123 | pub fn get_color(&self, color: char) -> u8 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/view/coloring.rs:124:9
|
124 | / assert!(
125 | | color == 'R' || color == 'G' || color == 'B',
126 | | "Error: color should be equal to R, G, or B, color = {}",
127 | | color
128 | | );
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
docs for function returning `Result` missing `# Errors` section:
src/view/coloring.rs#L43
warning: docs for function returning `Result` missing `# Errors` section
--> src/view/coloring.rs:43:5
|
43 | pub fn new(r_g_b: &str) -> Result<ColorChannelMapping, String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
item in documentation is missing backticks:
src/view/coloring.rs#L10
warning: item in documentation is missing backticks
--> src/view/coloring.rs:10:10
|
10 | /// E.g: Ok(ColorChannelMapping::BGR) means that red will get the value of blue, green the value of green, and blue the value of red:
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
10 | /// E.g: `Ok(ColorChannelMapping::BGR`) means that red will get the value of blue, green the value of green, and blue the value of red:
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
item in documentation is missing backticks:
src/view/coloring.rs#L8
warning: item in documentation is missing backticks
--> src/view/coloring.rs:8:19
|
8 | ///A mapping from ColorChannelMapping -> RGB, the first character denotes the new red channel, the second character the new green channel,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
8 | ///A mapping from `ColorChannelMapping` -> RGB, the first character denotes the new red channel, the second character the new green channel,
| ~~~~~~~~~~~~~~~~~~~~~
|
the function has a cognitive complexity of (7/5):
src/model/rendering.rs#L102
warning: the function has a cognitive complexity of (7/5)
--> src/model/rendering.rs:102:41
|
102 | let handle = thread::spawn(move || {
| ^^
|
= help: you could split it up into multiple smaller functions
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cognitive_complexity
= note: `#[warn(clippy::cognitive_complexity)]` implied by `#[warn(clippy::nursery)]`
|
using `clone` on type `fn(u32, u32) -> TrueColor` which implements the `Copy` trait:
src/model/rendering.rs#L100
warning: using `clone` on type `fn(u32, u32) -> TrueColor` which implements the `Copy` trait
--> src/model/rendering.rs:100:33
|
100 | let coloring_function = (mandelbrot_model.coloring_function).clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(mandelbrot_model.coloring_function)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
temporary with significant `Drop` can be early dropped:
src/model/mandelbrot_model.rs#L46
warning: temporary with significant `Drop` can be early dropped
--> src/model/mandelbrot_model.rs:46:13
|
45 | pub fn get_instance() -> MutexGuard<'static, MandelbrotModel> {
| ___________________________________________________________________-
46 | | let lock = MANDELBROT_MODEL_INSTANCE.try_lock();
| | ^^^^
47 | | if let Ok(instance) = lock {
48 | | return instance;
49 | | }
50 | | panic!("You have called the singleton twice! This should never happen. It means that within the same scope, MandelbrotModel::get_...
51 | | }
| |_____- temporary `lock` is currently being dropped at the end of its contained scope
|
= note: this might lead to unnecessary resource contention
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening
note: the lint level is defined here
--> src/lib.rs:4:5
|
4 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::significant_drop_tightening)]` implied by `#[warn(clippy::nursery)]`
help: merge the temporary construction with its single usage
|
46 ~
47 + MANDELBROT_MODEL_INSTANCE.try_lock().;
|
help: remove separated single usage
|
47 - if let Ok(instance) = lock {
48 - return instance;
49 - }
47 +
|
|
docs for function which may panic missing `# Panics` section:
src/model/mandelbrot_model.rs#L45
warning: docs for function which may panic missing `# Panics` section
--> src/model/mandelbrot_model.rs:45:5
|
45 | pub fn get_instance() -> MutexGuard<'static, MandelbrotModel> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/model/mandelbrot_model.rs:50:9
|
50 | ... panic!("You have called the singleton twice! This should never happen. It means that within the same scope, MandelbrotModel::get_instance() was called more than once....
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
item in documentation is missing backticks:
src/model/mandelbrot_model.rs#L44
warning: item in documentation is missing backticks
--> src/model/mandelbrot_model.rs:44:31
|
44 | /// Returns the singleton MandelbrotModel instance.
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
|
44 | /// Returns the singleton `MandelbrotModel` instance.
| ~~~~~~~~~~~~~~~~~
|
using `clone` on type `Config` which implements the `Copy` trait:
src/model/mandelbrot_model.rs#L34
warning: using `clone` on type `Config` which implements the `Copy` trait
--> src/model/mandelbrot_model.rs:34:21
|
34 | config: config.clone(),
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
note: the lint level is defined here
--> src/lib.rs:9:5
|
9 | clippy::complexity
| ^^^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::clone_on_copy)]` implied by `#[warn(clippy::complexity)]`
|
you should consider adding a `Default` implementation for `MandelbrotModel`:
src/model/mandelbrot_model.rs#L28
warning: you should consider adding a `Default` implementation for `MandelbrotModel`
--> src/model/mandelbrot_model.rs:28:5
|
28 | / pub fn new() -> MandelbrotModel {
29 | | let config = Config::build(env::args()).unwrap_or_else(|err| {
30 | | eprintln!("Problem parsing arguments: {}", err);
31 | | process::exit(1);
... |
41 | | }
42 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
27 + impl Default for MandelbrotModel {
28 + fn default() -> Self {
29 + Self::new()
30 + }
31 + }
|
|
docs for function which may panic missing `# Panics` section:
src/controller/user_input.rs#L31
warning: docs for function which may panic missing `# Panics` section
--> src/controller/user_input.rs:31:1
|
31 | pub fn get_user_input_untrimmed() -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/controller/user_input.rs:34:5
|
34 | / io::stdin()
35 | | .read_line(&mut user_input)
36 | | .expect("Error: Failed to read the user's input from stdin.");
| |_____________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> src/lib.rs:3:5
|
3 | clippy::pedantic,
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|
you should consider adding a `Default` implementation for `Config`:
src/controller/config.rs#L32
warning: you should consider adding a `Default` implementation for `Config`
--> src/controller/config.rs:32:5
|
32 | / pub fn new() -> Config {
33 | | Config {
34 | | window_width: WIDTH,
35 | | window_height: HEIGHT,
... |
42 | | }
43 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
note: the lint level is defined here
--> src/lib.rs:2:5
|
2 | clippy::all,
| ^^^^^^^^^^^
= note: `#[warn(clippy::new_without_default)]` implied by `#[warn(clippy::all)]`
help: try adding this
|
31 + impl Default for Config {
32 + fn default() -> Self {
33 + Self::new()
34 + }
35 + }
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
benchmark
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|