Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding when single page breaks functionality #136

Closed
richgoldmd opened this issue Sep 27, 2016 · 2 comments
Closed

Hiding when single page breaks functionality #136

richgoldmd opened this issue Sep 27, 2016 · 2 comments

Comments

@richgoldmd
Copy link

There was a recent change that involves this code:

        // hide if only one page exists
        if (this.options.totalPages == 1) {
            return this;
        }

This breaks functionality, as the controls aren't built and the onPageClick is not called for the first page. In my project we use this to power an ajax driven data loader, by tearing down and rebuilding the control, but we never get the initial event to load the data. This functionality should be optional if it remains.

@eugenesimakin
Copy link
Collaborator

Hi!
Please, check the fix

@richgoldmd
Copy link
Author

Nice! Works perfectly. Thank you, and thanks for an excellent plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants