Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: private folder #504

Closed
wants to merge 3 commits into from
Closed

Conversation

q962
Copy link

@q962 q962 commented Jul 18, 2024

Allow private windows and normal windows to manage their own tabs

#501

@q962
Copy link
Author

q962 commented Jul 18, 2024

I don't understand why my code is timing out.

Also, the test cases that are timing out are different.

I don't understand why.

    puts items in bookmark folders
      1) moves bookmarks from different folders into the target folder
      2) "after each" hook: afterEach for "moves bookmarks from different folders into the target folder"


  288 passing (5s)
  2 failing

  1) model
       puts items in bookmark folders
         moves bookmarks from different folders into the target folder:
         or
         skips or steals duplicates when putting items in the same folder:
         or ... 

     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (\tab-stash\src\model\index.test.ts)
      at listOnTimeout (node:internal/timers:573:17)
      at processTimers (node:internal/timers:514:7)

  2) "after each" hook: afterEach for "moves bookmarks from different folders into the target folder":
     Error: Test finished before all events were processed.

Waiters: [ { event: 'browser.bookmarks.onMoved/undefined' } ]

Pending Events: []
      at Object.afterTest (src\mock\events.ts:253:2)
      at Context.afterEach (src\mock\index.ts:13:612)
      at processImmediate (node:internal/timers:478:21)

@q962 q962 changed the title Feature private folder Feature: private folder Jul 18, 2024
@josh-berry
Copy link
Owner

Gonna close this based on our discussion on #501, but let me know if you're still interested in pursuing it.

@josh-berry josh-berry closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants