Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

fix: delete and backspace behavior for multi-byte characters #57

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

joshka
Copy link
Owner

@joshka joshka commented Jul 5, 2024

Fixes: #56

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (5570e49) to head (2e7a68e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   85.51%   89.63%   +4.12%     
==========================================
  Files           4        4              
  Lines         497      550      +53     
==========================================
+ Hits          425      493      +68     
+ Misses         72       57      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederictobiasc
Copy link
Contributor

LGTM!

@joshka joshka merged commit 6060efe into main Jul 8, 2024
11 checks passed
@joshka joshka deleted the jm/fix-delete branch July 8, 2024 09:50
@joshka
Copy link
Owner Author

joshka commented Jul 8, 2024

Thanks for checking this out @frederictobiasc

@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Deleting in Strings with multi-byte-characters panics
3 participants