Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouse: screen flip does not work #691

Closed
jotego opened this issue Jun 3, 2024 · 15 comments
Closed

shouse: screen flip does not work #691

jotego opened this issue Jun 3, 2024 · 15 comments
Assignees
Labels
question Further information is requested

Comments

@jotego
Copy link
Owner

jotego commented Jun 3, 2024

It was reported in Discord that changing the flip setting in Dragon Spirit does not work. @jtmiki, could you test it?

@jotego jotego added the question Further information is requested label Jun 3, 2024
@jotego jotego added this to the Namco System 1 milestone Jun 3, 2024
Repository owner deleted a comment from jtmiki Jun 3, 2024
@jtmiki
Copy link
Collaborator

jtmiki commented Jun 5, 2024

I tested it and it does not work.
When you ON the Flip setting, it goes OFF automatically.
The orientation of the HDMI screen display remains the same, but the CRT screen display turns downwards or upwards during processing and eventually turns upwards.
Commit: 1bb5cb0

@jotego jotego self-assigned this Jun 26, 2024
@jotego
Copy link
Owner Author

jotego commented Jun 26, 2024

The flip setting is changed in the service menu. You enter the service menu using the DIP switches. Changing it does change the dip_flip signal in the game module. That affects MiSTer's HDMI rotation settings so it flips the screen but the tilemap seems to be flipped by the software at the same time. So the net effect is no flip in the CRT, while there is flip in the HDMI output because of MiSTer's rotation setting changing.

@jotego
Copy link
Owner Author

jotego commented Jun 26, 2024

The flip mode does not work at all. There is no way to flip the tilemap at the moment, even if the flip signal going into the tilemap module is altered manually.

@jotego jotego changed the title shouse: dspirit does not react to changes to DIP settings shouse: screen flip does not work Jun 26, 2024
@gyurco
Copy link
Collaborator

gyurco commented Aug 2, 2024

Where's the flip setting?

The hardware has a software flip register, some games set it, others not. But it cannot be override externally, as it requires some cooperation from the software side (coordinates are different in the two modes).

@jotego
Copy link
Owner Author

jotego commented Aug 2, 2024

Use the DIP settings to enter the service mode in Dragon Spirit. You will see options that presumably get saved in the EEPROM. These two screenshots are from MAME:

Default:
0000

And when you turn it on:
0001

@gyurco
Copy link
Collaborator

gyurco commented Aug 2, 2024

I see now.
The current code is aware of the changed coordinates in flip/non-flip modes, but that's all, it doesn't actually draws a flipped screen.

@gyurco gyurco self-assigned this Aug 3, 2024
@gyurco
Copy link
Collaborator

gyurco commented Aug 3, 2024

Just a side question: is 'rotate controls' broke recently? The OSD option is there, but it doesn't do anything even if I switch between 'yes' and 'no'. I also noticed it in kchamp.

gyurco added a commit that referenced this issue Aug 3, 2024
gyurco added a commit that referenced this issue Aug 4, 2024
@jotego
Copy link
Owner Author

jotego commented Aug 4, 2024

I do not remember doing anything to it lately...

@gyurco
Copy link
Collaborator

gyurco commented Aug 4, 2024

I do not remember doing anything to it lately...

The problem was that MRA tool didn't handle rom index=1 when it was more than one byte. I updated the tool.

@jotego
Copy link
Owner Author

jotego commented Aug 5, 2024

I do not remember doing anything to it lately...

The problem was that MRA tool didn't handle rom index=1 when it was more than one byte. I updated the tool.

I see. I normally let jtframe create ROM/RAM files for my cores so I did not notice. Thanks for checking it.

@jotego
Copy link
Owner Author

jotego commented Aug 5, 2024

I had to override core_mod calculation for this core as the information coming from dip_flip contradicts MAME's database for Pac-Mania. See f548a46

This task is completed. Thanks @gyurco

@jotego jotego closed this as completed Aug 5, 2024
@gyurco
Copy link
Collaborator

gyurco commented Aug 5, 2024

I had to override core_mod calculation for this core as the information coming from dip_flip contradicts MAME's database for Pac-Mania. See f548a46

As I see, Galaga88 also flipped by default.

@stiegis
Copy link

stiegis commented Aug 7, 2024

Is this being realeased in the next update? Cannot flip cores on a crt monitor but works in hdmi perfectly. No big problem as I can swap joke connectors on the monitor but this is not very practical as other games cannot be flipped then

@jotego
Copy link
Owner Author

jotego commented Aug 7, 2024

Is this being realeased in the next update? Cannot flip cores on a crt monitor but works in hdmi perfectly. No big problem as I can swap joke connectors on the monitor but this is not very practical as other games cannot be flipped then

Yes, it will be released in the next update.

@stiegis
Copy link

stiegis commented Aug 7, 2024

thanks Jotego thats great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants