Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/speed map #156

Merged
merged 4 commits into from
May 26, 2024
Merged

Conversation

pixelspark
Copy link
Contributor

This slightly refactors the map code to avoid using globals, and adds a speed layer to the map (which can be toggled).

Only issue appears to be that the layers icon is not included yet.

image

@jovandeginste
Copy link
Owner

I really like this; however, there seems to be a cosmetic issue for me: when I'm not hovering over the height vs speed selection, it's a white square, which does not give any hints that you could do something with it... Is this different in your setup? Or can we add anything in there when not hovering, to hint that you could do something there?

image

@pixelspark
Copy link
Contributor Author

I am seeing the same thing (this is what I referred to with "Only issue appears to be that the layers icon is not included yet.".

It appears Leaflet expects an image file somwhere (see your Network tab in the web inspector, it will have a 404 in there I assume). We need to find the icon from Leaflet or create an icon for this ourselves and put it in the right place.

@jovandeginste
Copy link
Owner

Aha thanks; didn't have much time this morning, will look into it later too, unless you found it before.

@pixelspark
Copy link
Contributor Author

It wants to load http://localhost:8080/assets/dist/images/layers.png, fixed it by copying all leaflet images to the dist folder in the Makefile.

@jovandeginste jovandeginste merged commit 17f8f23 into jovandeginste:master May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants