Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnecting output device halts playback permanently #449

Open
HookedBehemoth opened this issue Jan 18, 2024 · 3 comments
Open

Disconnecting output device halts playback permanently #449

HookedBehemoth opened this issue Jan 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@HookedBehemoth
Copy link
Contributor

Describe the bug
I'm using bluetooth headphones which automatically turn off when placed back in their case. This halts playback entirely and only restarting the entire application fixes it.
Down below is an application log, stripped of absolute paths.
Maybe related: Switching the output device through the OS doesn't change it in psst.

To Reproduce

  • connect bluetooth headphones
  • launch psst
  • start playback
  • disconnect headphones
  • connect headphones again
  • try to unpause or play any other song

Expected behavior
Playback should be allowed to resume on the current primary output device or psst should offer an option to select a target device.

Screenshots
(No images provided as I don't see the reason here)

Environment

Additional context
Log of the hang

[2024-01-18T14:06:48Z INFO  psst_core::audio::output::cpal] using audio device: "Kopfhörer (2- WF-1000XM4)"
[2024-01-18T14:06:48Z INFO  psst_core::cache] using cache: "%APPDATA%\\Local\\Psst"
[2024-01-18T14:06:48Z INFO  psst_core::audio::output::cpal] opening output stream: StreamConfig { channels: 2, sample_rate: SampleRate(48000), buffer_size: Default }
[2024-01-18T14:06:48Z INFO  psst_gui::data::config] saved config: "%APPDATA%\\Roaming\\Psst\\config.json"
[2024-01-18T14:06:48Z INFO  psst_gui::data::config] saved config: "%APPDATA%\\Roaming\\Psst\\config.json"
[2024-01-18T14:06:48Z INFO  psst_core::session::access_token] access token expired, requesting
[2024-01-18T14:06:50Z INFO  symphonia_format_ogg::demuxer] starting new physical stream
[2024-01-18T14:06:50Z INFO  symphonia_format_ogg::demuxer] selected vorbis mapper for stream with serial=0x0
[2024-01-18T14:06:50Z INFO  psst_core::player] starting playback
[2024-01-18T14:06:50Z INFO  audio_thread_priority::rt_win] task 1317 bumped to real time priority.
[2024-01-18T14:11:26Z INFO  symphonia_format_ogg::demuxer] starting new physical stream
[2024-01-18T14:11:26Z INFO  symphonia_format_ogg::demuxer] selected vorbis mapper for stream with serial=0x0
[2024-01-18T14:11:26Z INFO  psst_core::player] preloaded audio file
[2024-01-18T14:11:50Z INFO  psst_core::player] pausing playback
[2024-01-18T14:11:53Z INFO  psst_core::player] resuming playback
[2024-01-18T14:11:56Z INFO  psst_core::player] pausing playback
[2024-01-18T14:11:57Z ERROR psst_core::audio::output::cpal] audio output error: The requested device is no longer available. For example, it has been unplugged.
[2024-01-18T14:12:21Z INFO  psst_core::player] resuming playback
[2024-01-18T14:12:21Z ERROR psst_core::audio::output::cpal] output stream actor is dead
[2024-01-18T14:12:21Z ERROR psst_core::audio::output::cpal] failed to start stream: the device associated with the stream is no longer available
[2024-01-18T14:12:26Z INFO  psst_core::player] pausing playback
[2024-01-18T14:12:26Z ERROR psst_core::audio::output::cpal] output stream actor is dead
[2024-01-18T14:12:26Z ERROR psst_core::audio::output::cpal] failed to stop stream: the device associated with the stream is no longer available
@HookedBehemoth HookedBehemoth added the bug Something isn't working label Jan 18, 2024
@ll01
Copy link

ll01 commented Mar 21, 2024

I have a similar issue too.

@TheMargarineMan
Copy link

This issue is replicated by disabling devices in windows sound settings. This issue seems to stem from how psst handles its audio devices, initializing a stream on the default device at start. To change this to handle switching between audio sources and disconnects may require a large amount of effort.

@sidit77
Copy link

sidit77 commented May 29, 2024

Around a year ago, I created RustAudio/cpal#754 to fix this issue, but it got no traction.
If anyone is interested in a quick fix for psst simply go to psst-core/Cargo.toml and replace

cpal = { version = "0.15.2", optional = true }

with

cpal = { git="https://github.com/sidit77/cpal", optional = true }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants