Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASAPI: Improve how default devices are created to support automatic stream routing #754

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sidit77
Copy link

@sidit77 sidit77 commented Feb 24, 2023

Use ActivateAudioInterfaceAsync to create default input/output devices to support automatic stream routing.

Related issues: #740

Open questions:

  • Fallback for windows versions <1607
  • Implementation of device name/eq
  • What happens when the is no default device (can this even happen?)

…able automatic stream routing in case the default device changes
# Conflicts:
#	Cargo.toml
#	src/host/wasapi/device.rs
@snylonue
Copy link

Will the pr be merged? The feature is quite important to handle device changes IMO.

# Conflicts:
#	Cargo.toml
#	src/host/wasapi/device.rs
@jacksongoode
Copy link

@est31 I would personally be able to revive/bring this PR forward if you have time to review - no worries if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants