Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with code embedded in tquery #11

Open
waldyrious opened this issue Aug 25, 2017 · 3 comments
Open

Merge with code embedded in tquery #11

waldyrious opened this issue Aug 25, 2017 · 3 comments

Comments

@waldyrious
Copy link
Collaborator

https://github.com/jeromeetienne/tquery/tree/master/www/vendor/doccoviewer

Perhaps make that directory a git submodule linking to this one? What do you think, @jeromeetienne?

@waldyrious
Copy link
Collaborator Author

waldyrious commented Aug 25, 2017

At the very least, both codebases should be reviewed and any differences sorted out.

In particular, we ought to compare the demos at http://jsinside.github.io/docco.js and http://jeromeetienne.github.io/tquery/www/vendor/doccoviewer/index.html#../../../plugins/car/examples/index.html: rendered output, browser errors, etc.

@jeromeetienne
Copy link
Contributor

jeromeetienne commented Aug 25, 2017 via email

@waldyrious
Copy link
Collaborator Author

Ok, I'll take care of the comparison and will let you know when this repo's output matches that of the hardcoded copy, so you can then embed it as a submodule without any regressions on the tquery side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants