Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension touchscreen buttons #101

Merged

Conversation

younesStrittmatter
Copy link
Contributor

new version (incompatible with previous version!)

added features:

  • naming of layouts instead of layout-array
  • arbitrary number of buttons as button array instead of max number of buttons
  • position and size more easily adjustable

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: a2a5685

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jspsych-contrib/extension-touchscreen-buttons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jodeleeuw jodeleeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @younesStrittmatter ! Just one quick fix for the version and then I can merge.

@@ -1,6 +1,6 @@
{
"name": "@jspsych-contrib/extension-touchscreen-buttons",
"version": "1.0.0",
"version": "2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be manually updated. The GitHub action will update this based on the change set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I reverted the change

@@ -10,7 +10,7 @@ This extension displays touch buttons allows the subject to respond to stimuli v
### In browser

```js
<script src="https://unpkg.com/@jspsych-contrib/extension-touchscreen-buttons@1.0.0">
<script src="https://unpkg.com/@jspsych-contrib/extension-touchscreen-buttons@2.0.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to be manually updated, but won't cause any problems if you do manually update.

@jodeleeuw jodeleeuw merged commit b4821b4 into jspsych:main Feb 7, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants