plugin-meye-config & extension-meye

[AdamVasarhelyi2]

Presenting a new plugin (plugin-meye-config) and extension (extension-meye) for review. Steps to verify functionality:

In cmd.exe:

1. Run npm install in the root directory

2. Run npm run build inside packages/plugin-meye-config and packages/extension-meye

3. Navigate to /packages (i.e., go up a directory)

4. Run a local python server with python -m http.server

5. In your web browser, navigate to http://localhost:8000/

6. To test the plugin, navigate to /plugin-meye-config/examples. To test the extension, navigate to /extension-meye/examples. Note that the extension example calls the index.browser.min.js file from the plugin's /dist directory as the plugin and extension are to be used together.

7. Once the examples finish, they output data that you can examine.

The original website for the technology implemented by the plugin / extension is https://www.pupillometry.it/

In both the original mEye and the plugin, it is difficult for calibration to be perfect (it is harder in the original website because calibration must be done manually, but has been automatized in the plugin). If testing is difficult due to lighting constraints, you can print out a picture of an eye and hold it up to the camera. If you put your hand over the pupil, the extension's data for blink probability should increase to 1.

Please let me know if you have any questions :)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1182d07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[jodeleeuw]

Hi @AdamVasarhelyi2,

Thanks for the contribution!

It looks like there are files in dist/ folders that are being committed here. These should be ignored via .gitignore. I'm wondering if they aren't being caught because you uploaded them directly. Can you remove these from the PR?

[AdamVasarhelyi2]

Sure Josh! Thanks for the feedback - I'm a little new :P

I'll get this done by Monday

[AdamVasarhelyi2]

Hi @AdamVasarhelyi2,

Thanks for the contribution!

It looks like there are files in dist/ folders that are being committed here. These should be ignored via .gitignore. I'm wondering if they aren't being caught because you uploaded them directly. Can you remove these from the PR?

Hey Josh sorry for taking forever, I'm in a super hectic part of my last semester at college. I'll get around to this soon :)

[AdamVasarhelyi2]

Hey @jodeleeuw, I've finally gotten around to this. Sorry for taking so long!! I hope everything's okay now - I (think I) have removed the files from the /dist directory that were causing problems with the first submission. Please let me know if everything is okay!

[jodeleeuw]

@AdamVasarhelyi2, sorry for letting this slip through the cracks! I've updated a few things to match existing conventions. The next step is getting the package-lock.json to update, but I don't have permission to push directly to your fork for that. Can you pull my changes and then run npm i in the root of the repository to generate an updated package-lock.json file? When you push that I think the build should work.

[AdamVasarhelyi2]

Thanks a lot, Josh! Means a lot to me that we can get this working 😄 I also happened to check this email account by accident and am much more reliable on ***@***.*** Will get to work! Adam

…

________________________________ From: Josh de Leeuw ***@***.***> Sent: Wednesday, July 10, 2024 12:21 AM To: jspsych/jspsych-contrib ***@***.***> Cc: Adam Vasarhelyi ***@***.***>; Mention ***@***.***> Subject: Re: [jspsych/jspsych-contrib] plugin-meye-config & extension-meye (PR #73) @AdamVasarhelyi2<https://github.com/AdamVasarhelyi2>, sorry for letting this slip through the cracks! I've updated a few things to match existing conventions. The next step is getting the package-lock.json to update, but I don't have permission to push directly to your fork for that. Can you pull my changes and then run npm i in the root of the repository to generate an updated package-lock.json file? When you push that I think the build should work. — Reply to this email directly, view it on GitHub<#73 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHOQRSZJGMBSCNSA4S5TJGDZLPWWFAVCNFSM6AAAAABKS4XTP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXHA3TCNZZGA>. You are receiving this because you were mentioned.

[AdamVasarhelyi2]

Hey Josh! All done 🙂 It's kind of fun learning git! Let me know if you need me to do anything else. Thanks. Adam

…

________________________________ From: Josh de Leeuw ***@***.***> Sent: Wednesday, July 10, 2024 12:21 AM To: jspsych/jspsych-contrib ***@***.***> Cc: Adam Vasarhelyi ***@***.***>; Mention ***@***.***> Subject: Re: [jspsych/jspsych-contrib] plugin-meye-config & extension-meye (PR #73) @AdamVasarhelyi2<https://github.com/AdamVasarhelyi2>, sorry for letting this slip through the cracks! I've updated a few things to match existing conventions. The next step is getting the package-lock.json to update, but I don't have permission to push directly to your fork for that. Can you pull my changes and then run npm i in the root of the repository to generate an updated package-lock.json file? When you push that I think the build should work. — Reply to this email directly, view it on GitHub<#73 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHOQRSZJGMBSCNSA4S5TJGDZLPWWFAVCNFSM6AAAAABKS4XTP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXHA3TCNZZGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>