Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to account for internal environments #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teruokun
Copy link

With the new internal environments used for hatch test, hatch fmt, and the internal uv installation, this allows for accounting for the internal environments with --all or by name when updating the constraint files for those environments.

@juftin
Copy link
Owner

juftin commented Jul 17, 2024

Oh nice, this looks great. This project does quite a bit to maintain compatibility with hatch>=1.7,<2.0 - could you add a conditional check on the hatch version before adding the --internal flag to maintain backwards compatibility?

@teruokun
Copy link
Author

Sure, I had originally thought about doing that but hesitated since it added more complexity to the overall logic so I thought I'd go simple first, but it should be relatively straight-forwards. I'll try to get that done today

@teruokun
Copy link
Author

Alright, the updates do a parametrize on the mocked cli tests and adds in the hatch version check (wasn't sure if there was already a utility for that or not, but if there is I'm happy to not re-invent it)

@teruokun
Copy link
Author

@juftin can you take a look at the newest revision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants