Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_uri is deprecated from group keystone_authtoken #750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulsinghcanonical
Copy link

The option "auth_uri" from group "keystone_authtoken" is deprecated for removal. The auth_uri token is deprecated in favor of www_authenticate_uri. This commit changes the use of auth_uri to www_authenticate_uri correctly.

Fixes #749

The option "auth_uri" from group "keystone_authtoken" is deprecated for removal. The auth_uri token is deprecated in favor of www_authenticate_uri.
This commit changes the use of auth_uri to www_authenticate_uri correctly.
ajkavanagh
ajkavanagh previously approved these changes Nov 29, 2022
@ajkavanagh ajkavanagh dismissed their stale review November 29, 2022 15:03

I didn't quite think things through.

@ajkavanagh
Copy link
Contributor

So the associated review needs work (a c-h sync from this branch/PR) before it can verify the changes.

@ajkavanagh ajkavanagh added Incomplete For an issue, needs more information. For a PR, needs further work. stale Nobody has touched anything in quite a while; probably abandoned or forgotten. labels May 8, 2023
@ajkavanagh
Copy link
Contributor

@rahulsinghcanonical Just to clarify:

So the associated review needs work (a c-h sync from this branch/PR) before it can verify the changes.

What I mean is, that an API service (e.g. cinder) needs to have this change synced into it (make sync); if the PR that was recently abandoned is updated then it will test this PR and thus we can move to merge the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete For an issue, needs more information. For a PR, needs further work. stale Nobody has touched anything in quite a while; probably abandoned or forgotten.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth_uri is deprecated from group keystone_authtoken
2 participants