Fail and retry on "Some index files failed to download" #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APT doesn't error out even in the following case since it's a warning instead of an error. And it allows charms to move on without having a proper APT index and let them install unwanted versions of software for example. The apt_update part should fail if it's marked as fatal in such cases so that it can be retried or charm can raise it as an error to users appropriately. "--error-on=any" is supported for >= bionic. https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1693900 Closes: juju#910 [w/o "--error-on=any"] ``` $ sudo apt-get update; echo $? ... Err:2 http://security.ubuntu.com/ubuntu jammy-security InRelease Could not connect to squid-deb-proxy.lxd:8000 (10.0.8.2). - connect (113: No route to host) Err:1 http://archive.ubuntu.com/ubuntu jammy InRelease Could not connect to squid-deb-proxy.lxd:8000 (10.0.8.2). - connect (113: No route to host) Err:3 http://archive.ubuntu.com/ubuntu jammy-updates InRelease Unable to connect to squid-deb-proxy.lxd:8000: Err:4 http://archive.ubuntu.com/ubuntu jammy-backports InRelease Unable to connect to squid-deb-proxy.lxd:8000: Reading package lists... Done W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/jammy/InRelease Could not connect to squid-deb-proxy.lxd:8000 (10.0.8.2). - connect (113: No route to host) W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/jammy-updates/InRelease Unable to connect to squid-deb-proxy.lxd:8000: ... W: Some index files failed to download. They have been ignored, or old ones used instead. ``` -> 0 [w/ "--error-on=any"] ``` $ sudo apt-get --error-on=any update; echo $? ... E: Some index files failed to download. They have been ignored, or old ones used instead. ``` -> 100
nobuto-m
added a commit
to nobuto-m/operator-libs-linux
that referenced
this pull request
Aug 21, 2024
In scripting apt operations, adding `--error-on=any` to `apt-get update` is necessary to capture erros like "Some index files failed to download". Otherwise, charms move onto package installations with a stale index. equivalent to: juju/charm-helpers#911 ref: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1693900
benhoyt
pushed a commit
to canonical/operator-libs-linux
that referenced
this pull request
Aug 21, 2024
* Fail and retry on "Some index files failed to download" In scripting apt operations, adding `--error-on=any` to `apt-get update` is necessary to capture erros like "Some index files failed to download". Otherwise, charms move onto package installations with a stale index. equivalent to: juju/charm-helpers#911 ref: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1693900 * Bump the patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APT doesn't error out even in the following case since it's a warning instead of an error. And it allows charms to move on without having a proper APT index and let them install unwanted versions of software for example. The apt_update part should fail if it's marked as fatal in such cases so that it can be retried or charm can raise it as an error to users appropriately.
"--error-on=any" is supported for >= bionic.
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1693900
Closes: #910
[w/o "--error-on=any"]
-> 0
[w/ "--error-on=any"]
-> 100