Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WD-9334 - fix: use callback resolve and reject #123

Merged
merged 12 commits into from
Mar 6, 2024
Merged

WD-9334 - fix: use callback resolve and reject #123

merged 12 commits into from
Mar 6, 2024

Conversation

vladimir-cucu
Copy link
Contributor

@vladimir-cucu vladimir-cucu commented Feb 26, 2024 •
edited
Loading

Done

  • Use callback resolve/reject for error/successful request in Transport instead of resolving with string for error and resolving with other type for successful request.

Details

@vladimir-cucu vladimir-cucu marked this pull request as ready for review March 4, 2024 05:49
@vladimir-cucu vladimir-cucu changed the title fix: use callback resolve and reject WD-9334 - fix: use callback resolve and reject Mar 4, 2024
huwshimi
huwshimi reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions here.

api/client.ts Outdated Show resolved Hide resolved
api/client.ts Outdated Show resolved Hide resolved
api/helpers.ts Outdated Show resolved Hide resolved
api/tests/test-client.ts Outdated Show resolved Hide resolved
api/utils.ts Outdated Show resolved Hide resolved
api/utils.ts Outdated Show resolved Hide resolved
huwshimi
huwshimi approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You could also update the version number in package.json to 6.0.0 ready for release.

@vladimir-cucu vladimir-cucu merged commit c4d930b into juju:master Mar 6, 2024
4 checks passed
@huwshimi huwshimi mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir-cucu @huwshimi