Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration from state if it was removed manually (#186) #192

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

amandahla
Copy link
Contributor

Description

Currently, if integration is removed manually, terraform plan fails with "no integrations exist in specified model". This PR changes the behavior to remove it from the state instead.

Type of change

Please mark if proceeds.

  • New resource (a new resource in the schema)
  • Changed resource (changes in an existing resource)
  • Logic changes in resources (the API interaction with Juju has been changed)
  • Test changes (one or several tests have been changed)
  • [X ] Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other (describe)

Environment

  • Juju controller version: 2.9.42
  • Terraform version: 1.4.4

QA steps

Manual QA steps should be done to test this PR.

The same that was reported in issue #186

Additional notes

It might be worth doing this for all the resources and also creating a specific error for that instead of checking the error message.

@juanmanuel-tirado
Copy link
Contributor

The situation reported in #186 cannot be reproduced after #189 was landed. This is a good check.

Thanks for the PR!!

@juanmanuel-tirado
Copy link
Contributor

@amandahla I'm OK with the changes. Failing tests are not due to these changes. Ready to merge if you're OK with the PR.

@juanmanuel-tirado
Copy link
Contributor

Fix #186
Fix #187

@amandahla
Copy link
Contributor Author

@amandahla I'm OK with the changes. Failing tests are not due to these changes. Ready to merge if you're OK with the PR.

Awesome! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants