Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base in application #325

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Base in application #325

merged 2 commits into from
Oct 20, 2023

Conversation

hmlanigan
Copy link
Member

Description

Add base to charm in application, series is now deprecated. The second part of adding bases to terraform.

Until we move to using juju 3.x api code, most operating system determination work must still be done in series due to the help functions.

Related to: #249

Type of change

  • Change existing resource
  • Requires a documentation update

QA steps

Both should deploy, one will give a deprecation notice. They will find Xenial by default, so Jammy ensures the operating system selection is working.

provider "juju" {
}

resource "juju_model" "testmodel" {
  name = "base"
}

resource "juju_application" "application_three" {
  model = juju_model.testmodel.name
  charm {
    name = "juju-qa-dummy-source"
    series = "jammy"
  }
}

resource "juju_application" "application_one" {
  model = juju_model.testmodel.name
  charm {
    name = "juju-qa-dummy-sink"
    base = "[email protected]"
  }
}

Additional notes

JUJU-4037

It shouldn't reference the old series nomenclature.
Copy link
Contributor

@cderici cderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. QA went well 👍

internal/juju/applications.go Outdated Show resolved Hide resolved
internal/juju/applications.go Outdated Show resolved Hide resolved
Will replace series which is now deprecated. Due to use of the 2.9.45
code base, most operating system pieces will be handled as a series
still. But this gives users a transition to be able to use bases.

Remove unused elemented of CreateApplicationResponse. ReadApplication
is necessary for all required data anyway.
@hmlanigan hmlanigan merged commit b55c592 into juju:main Oct 20, 2023
16 checks passed
@hmlanigan hmlanigan deleted the base-in-application branch October 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants