Dependencies - update terraform-plugin-framework minor version #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmlanigan
changed the title
|
This change of the framework pkg version from 1.3.x to 1.4.x causes test failures which need to be resolved. Holding off until after 0.10.1 get's released. |
hmlanigan
force-pushed
the
dependencies
branch
from
54a4646
to
202837a
Compare
hmlanigan
force-pushed
the
dependencies
branch
from
202837a
to
8c37f8e
Compare
This is a minor version change which improve interactions with terraform 1.6. Requires go 1.20 which we already use.
Inline with framework package updates as well.
recent dependabot failed PRs.
Get the actual machine base and series data after it's been started. Cannot assume that the plan has any or all of the data as we had been doing. Added a read machine with retry method to wait for the data. Fix where the manual machine provisioning was not returning the machine base.
hmlanigan
force-pushed
the
dependencies
branch
3 times, most recently
from
f3bc51e
to
6b7e4c5
Compare
A Jira ticket exists to fix this test.
hmlanigan
force-pushed
the
dependencies
branch
from
6b7e4c5
to
22c95df
Compare
hmlanigan
changed the title
cderici
approved these changes
Feb 8, 2024
| } | ||
| }, | ||
| BackoffFunc: retry.DoubleDelay, | ||
| Attempts: 30, |
There was a problem hiding this comment.
is 30 attempts a little too many?
There was a problem hiding this comment.
30 is arbitrary for sure. In practicality, it's a max time of 61 sec due to the backoff func of DoubleDelay and wait time of 1 sec.
We also have the ctx.Done() that's passed through from the terraform client as a backstop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
Hopefully this will make dependabot happy. We've had at least 4 PRs of package updates, fail to compile recently due to code in dependencies. #355, #341, #331, #330, #321, #391, #382
Updated the README to use 1.6 while I'm here, the framework package has updates to improve performance with 1.6.
The test disabled in f3bc51e will be fixed in a follow on PR. It's an existing issue and not a regression.
Type of change
Additional Info
JUJU-5182