Replace strategy.matrix.include use. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ended up not doing what was expected, only 3 jobs rather than 12. Could re-write using include, but it is not intuitive. This accomplishes what we want as well.
hmlanigan
force-pushed
the
matrix-strategy-includes-addy
branch
from
4f2d71c
to
9688f0a
Compare
|
rebased with changes to fix the tests |
|
#375 landed and has fixed the tests. |
cderici
approved these changes
Jan 9, 2024
hmlanigan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strategy.matrix.include has non intuitive use. See the docs for more info.
To test what we want, define sets of values to be used together.
For each terraform 1.4, 1.5 and 1.6 test with each:
There should be 12 test runs with the above combination.
JUJU-4544