Fixes Config/Revision update ordering.

[anvial]

Description

This PR puts a Revision update before a Config update in the update plan function of the plugin. This will help to avoid issues that prevent working with new config parameters, which are added in new charm revisions.

Fixes:

#389

Type of change

• Logic changes in resources (the API interaction with Juju has been changed)
• (WIP) Change in tests (one or several tests have been changed)

Environment

• Juju controller version:
  3.3.1

• Terraform version:
  1.7.3

QA steps

Manual QA steps should be done to test this PR.

juju boostrap microk8s k8s
juju add-model test

Apply plan:

terraform {
  required_providers {
    juju = {
      source  = "juju/juju"
      version = "0.11.1"
    }
  }
}
provider "juju" {}

resource "juju_application" "githubrunner" {
  name  = "github-runner"
  model = "test"


  charm {
    name     = "github-runner"
    revision = 8
    channel  = "latest/edge"
  }

  units = 1
}

Then update plan to

terraform {
  required_providers {
    juju = {
      source  = "juju/juju"
      version = "0.11.1"
    }
  }
}
provider "juju" {}

resource "juju_application" "githubrunner" {
  name  = "github-runner"
  model = "test"


  charm {
    name     = "github-runner"
    revision = 10
    channel  = "latest/edge"
  }

  config = {
    group = "mygroup"
   }

  units = 1
}

[anvial]

@hmlanigan, looks like we have problems with the acceptance tests regardless to this PR. Need to discuss with you of how to fix them.

[hmlanigan]

@anvial If you've rebased this week, some 2.9 tests will fail because juju 2.9.47 hasn't been released yet (see #405 ). Failures against juju 3.x should be investigated.

[hmlanigan]

@anvial, the plans in the qa steps should either create the model, or make it a data source if you run juju add-model ahead. While the given plan will work, it's not a good TF form as it doesn't reference the model.

[anvial]

@anvial, the plans in the qa steps should either create the model, or make it a data source if you run juju add-model ahead. While the given plan will work, it's not a good TF form as it doesn't reference the model.

But I thought that I create a model but this resource definition in plan:

resource "juju_model" "this" {
  name = "{{.ModelName}}"
}
...

Where modelName is generated for every test.

[hmlanigan]

But I thought that I create a model but this resource definition in plan:

@anvial I'm speaking of the QA steps in the PR description, not the ACC test you've written for the resource_application_test.go file.

[anvial]

But I thought that I create a model but this resource definition in plan:

@anvial I'm speaking of the QA steps in the PR description, not the ACC test you've written for the resource_application_test.go file.

Agreed,

Now fixed in the QA steps description also, but it looks like it should be fixed in both places because of the chosen charm for the test: "github-runner".

[hmlanigan]

QA was good with revisions 88 and 95.

Please make the test changes and let's squash as many commits as we can? Looks like 2 commits are sufficient.

Lastly the QA steps listed in the PR description need updates to handle the model.

[hmlanigan]

Just a note that a file has been duplicated and needs removal. Otherwise looks good.