Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-6244 Adds client ID and secret to the provider config. #424

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

alesstimec
Copy link
Member

Description

Added client ID and client secret to Juju provider config, which will allow terraform provider to log in to JAAS using these client credentials.

Updates Juju dependency to 3.5 that contains needed login changes.

Type of change

<What type of a change is this? Please keep one or more relevant lines from below and delete the others.>

  • Other: login method change

Environment

  • Juju controller version: 3.5

  • Terraform version:

QA steps

Manual QA steps should be done to test this PR.

provider juju {}
...

Additional notes

<Please add relevant notes & information, links to mattermost chats, other related issues/PRs, anything to help understand and QA the PR.>

@alesstimec alesstimec changed the title Adds client ID and secret to the provider config. CSS-6244 Adds client ID and secret to the provider config. Mar 5, 2024
@hmlanigan hmlanigan added this to the v.0.12.0 milestone Mar 5, 2024
@alesstimec alesstimec force-pushed the client-credentials-login branch 2 times, most recently from a8fe4bc to a8f02a3 Compare March 7, 2024 07:24
Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file: https://github.com/juju/terraform-provider-juju/blob/main/templates/index.md.tmpl needs updates to Authentication section related to this change. After run make docs to add the results.

The PR description has no QA steps.

Have you run the acceptance tests locally? Github is consistently getting failures on the lxd tests.

internal/provider/provider.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
@alesstimec alesstimec force-pushed the client-credentials-login branch 4 times, most recently from ba8ac13 to c86efa6 Compare April 16, 2024 13:31
@alesstimec alesstimec force-pushed the client-credentials-login branch 2 times, most recently from 83743e1 to 1b8512d Compare April 17, 2024 13:31
This change will allow for authentication using client ID and secret
when connecting to JAAS.

Updates Juju dependency to 3.5 that contains needed login changes.
Copy link
Contributor

@cderici cderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just completed manual QA against 3.4 and 3.5 and it went well, everything seems to be working fine.

I was able to provide and pass through the client_id and the client_secret just fine, and also the validation against mutual exclusivity with username/password seems to be working fine.

Though I couldn't test it against a real JAAS setup with Juju, I'll give it a green light, as i) I confirmed that the current functionality is working without any issues, ii) all the tests are passing, and iii) I imagine @alesstimec can confirm that it's working well on jaas as he's the one who needed this change in the first place.

@hmlanigan hmlanigan merged commit d27c343 into juju:main Apr 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants