Implement methods for user secrets management #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
ab59f89
to
fd55d5a
Compare
anvial
changed the title
hmlanigan
requested changes
Apr 1, 2024
hmlanigan
reviewed
Apr 2, 2024
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
b492242
to
78f7a60
Compare
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
2bcabd3
to
2136d39
Compare
hmlanigan
reviewed
Apr 7, 2024
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
2210a58
to
520fba0
Compare
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
520fba0
to
86933db
Compare
hmlanigan
reviewed
Apr 10, 2024
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
3 times, most recently
from
0fb39c5
to
c4fd529
Compare
hmlanigan
approved these changes
Apr 11, 2024
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
c4fd529
to
2aa33c5
Compare
This commit introduces internal/juju/userSecret and adds method to add user secrets. Implement internal Juju secrets add, update, and remove functionality This commit introduces several changes to the Juju client in the `internal/juju/client.go` file. It includes the implementation of methods for adding, updating, and removing secrets. Additionally, Furthermore, the commit includes changes to the `secret.go` file, introducing new types for managinng secrets. It also includes changes to the `interfaces.go` file, defining new interfaces for the Juju client API. Add secretURI to UpdateSecret Add secretURI to DeleteSecret Add AutoPrunt to UpdateSecret schema Add SecretId to ReadSecret func instead of name. Add lost Asserts. Add secretNotFoundError Extract mocks creation into separate suite. Introduce typedError(err) usage in ClientAPI funcs. Add renaming to UpdateSecret Use struct raather than pointer for Output structures. Introcue NewName in Update input struct. Use pointers in all places in structs where the parameter is not neccessary. Add base64 encoding co Create and change Read fucntion to get value with decode. Add base64 encoding for values in Update
anvial
force-pushed
the
JUJU-5713-implement-internal-juju-user-secrets-add-update-remove
branch
from
2aa33c5
to
e8358e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces internal/juju/userSecret and adds method to add user secrets.
Fixes:
Type of change
Extend internal juju client functionality to implement new User secretes resources and data source.
QA steps