test: parallelize tests #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Jul 9, 2024
Use the terraform framework ParallelTests, rather than Test, to speed up the test times.
Now that the acceptance tests use the ParallelTest method, setup our test make targets to use by default. 5 is an arbitrary number.
hmlanigan
force-pushed
the
parallelize-tests
branch
2 times, most recently
from
c92cdbd
to
1a0a6f2
Compare
Ensure test models have unique names when parallelization of test runs.
hmlanigan
force-pushed
the
parallelize-tests
branch
from
1a0a6f2
to
7387523
Compare
These tests were no longer useful. Update the 2 _Stables tests to be _UpgradeProvider tests instead. Most other resources and data sources already have them. Change the version of the terraform provider to upgrade from to be 0.12.0 which is the last release. 0.10.1 is showing a panic which has already been addressed.
Create a PARALLEL_TEST_COUNT which defaults to 3 to allow for customizations to parallel testing by a user. Rename EDGE_VERSION and make customizable by the user.
Running full out is causing juju failures right now, with the change to ParallelTest. Try not running the tests with the capability.
hmlanigan
force-pushed
the
parallelize-tests
branch
from
7387523
to
8a17042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the terraform plugin testing package ParallelTest to help speed up acceptance test time rather than a straight
t.Parallel()call. Update make test targets to include-parallel 1. To enable parallel testing in this repository, work needs to be done with the GitHub runners. We need new self-hosted ones, or rewrite them not to use the charmed-kubernetes setup GitHub action.A few tests needed updates to ensure that the model names were unique per run. Other tests needed to be updated to test ProviderUpgrade rather than doing nothing as they were.
Use 0.12.0 release to test Provider Upgrade, the panic seen sometimes with 0.10.1 has already been resolved there.
Type of change
QA steps
Setup and run the tests with
make testlxdandmake testmicrok8s