-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #499 Assumes in tests run by Theories #601
Conversation
public class AssumingInTheoriesTest { | ||
|
||
@Test | ||
public void noTheoryAnnotationMeansAssumeShouldIgnore(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of stylistic things:
- Please always put spaces before {
Great! Just a couple of stylistic issues to prevent unnecessary formatting changes down the road. |
Put { on first line with a space before it
Done. I think. Not sure I agree with not having detail messages in assertions, but it didn't add a lot in this particular case. |
Thanks! |
Fix for issue #499 Assumes in tests run by Theories
Thanks! Would you mind summarizing the change as well at https://github.com/KentBeck/junit/wiki/4.12-release-notes? |
Done. Sorry for the delay. On Thu, Jan 10, 2013 at 12:05 PM, David Saff [email protected]:
|
No problem. Thanks! |
Fixes an issue (#499) where Assume cannot be used in a method annotated
by @test if theories also exist in that test class.