Support for hierarchical context hierarchies

[bechte]

This is a pull-request for issue #816.
#816: Support for hierarchical context hierarchies - RunWith annotation will be resolved along the hierarchy of non-static member classes.

Discussions on this topic should happen in #816. I provided this pull-request mostly to show the changes more graphically.

[kcooney]

Are you sure you don't want to pass testClass instead of currentTestClass here? Passing the outermost class with @RunWith doesn't appear to solve #816

[bechte]

Thanks for this. Of course, testClass needs to be passed with buildRunner. I changed it and updated the pull request.

[kcooney]

Could you add a test?

[bechte]

Yes, of course. I couldn't find any tests for this class so I also added tests for the default case. Hope that's fine. Let me know if it needs any changes on those.

[kcooney]

LGTM

@dsaff any objections?

[bechte]

With the last commit, I didn't change any more line of production code, just added two more test cases that show that annotation on inner member classes are also handled while going upwards to the top level class.

Still, this has no effect on the JUnit default runner, because it does not allow inner member (non-static) classes.

[kcooney]

@bechte Yes, I saw that. Just making sure @dsaff doesn't have any objections to this code having a special case for inner classes.

[dsaff]

I'm OK with the change. But I do think there may need to be some documentation that devs can use in terms of the expected search path, especially about the fact that, if I'm reading it right, a superclass of the inner class will be used before the outer class. (This is understandable behavior, but should be doc'ed.)

[bechte]

Sounds Good. I will provide docs soon. Prob. at the weekend.

[bechte]

I added the documentation.

[kcooney]

LGTM. I'm assigning this to @dsaff since he requested the documentation.

[dsaff]

Unfortunately, the new docs still seem to leave unresolved the question of priority. Given:

@RunWith(R1.class)
public class Outer {
public class Inner extends Super {
}
}

@RunWith(R2.class)
public class Super {}

Does Inner run with R1 or R2?

[kcooney]

@dsaff RunWith is inherited, so inner will run with R2

[dsaff]

@kcooney, right. I think this is worth calling out explicitly in the documentation, because it's consistent behavior, but also potentially surprising.

[kcooney]

@bechte can you update the documentation to clarify the issue that @dsaff brought up? Thanks.

[bechte]

I'm sorry it took so long to reply. We had tremendous troubles in the last 5 weeks on work so I had hardly time for anything else. I modified the documentation. Thanks for reviewing.

[kcooney]

@dsaff do those updates resolve your concerns?

@bechte after David reviews the recent changes, do you think you want to squash some of those commits?

[dsaff]

Looks good to me, thanks!

[bechte]

Sure, makes totally sence. I squashed all commits into one. Thanks.

[bechte]

Thanks.

[kcooney]

@bechte no problem. Glad to help. Could you please update the release notes?

[bechte]

Sure, done.