-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the default 'Implementation-*' headers to the manifest #879
Add the default 'Implementation-*' headers to the manifest #879
Conversation
Added headers are: Implementation-Title: ${project.name} Implementation-Version: ${project.version} Implementation-Vendor-Id: ${project.groupId} Implementation-Vendor: ${project.organization.name} Related to #878 Signed-off-by: Ferry Huberts <[email protected]>
Wow, that was fast and simple! Could you build the jar locally, print out the manifest, and add it as a comment this pull? |
no problem:
|
looks good to me I believe @stefanbirkner and @marcphilipp are more knowledgeable about Maven, so I'll have one of them merge this. |
LGTM. @stefanbirkner: Any objections? |
LGTM |
Add the default 'Implementation-*' headers to the manifest
thanks guys! |
@fhuberts Could you please make a note at https://github.com/junit-team/junit/wiki/4.12-release-notes |
done |
Thanks. |
Added headers are:
Implementation-Title: ${project.name}
Implementation-Version: ${project.version}
Implementation-Vendor-Id: ${project.groupId}
Implementation-Vendor: ${project.organization.name}
Related to #878
Signed-off-by: Ferry Huberts [email protected]