Restore field names with f prefix. Fixes #960. #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefix has been removed by df00d5e, because we changed the coding style. Unfortunately IntelliJ IDEA reads ClassRequest.fTestClass and FilterRequest.fFilter via reflection. (See http://grepcode.com/file/repository.grepcode.com/java/ext/com.jetbrains/intellij-idea/13.0.0/com/intellij/junit4/JUnit4IdeaTestRunner.java/ ) This makes it impossible to start tests by using IntelliJ IDEA. There is already an issue at JetBrains: [IDEA-127349 ](http://youtrack.jetbrains.com/issue/IDEA-127349) We can revert the fix when this ticket is solved and most users are using an IntelliJ version with the fix.
kcooney
added a commit
that referenced
this pull request
Jul 24, 2014
Restore field names with f prefix. Fixes #960.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefix has been removed by df00d5e,
because we changed the coding style. Unfortunately IntelliJ IDEA reads
ClassRequest.fTestClass and FilterRequest.fFilter via reflection. (See
http://grepcode.com/file/repository.grepcode.com/java/ext/com.jetbrains/intellij-idea/13.0.0/com/intellij/junit4/JUnit4IdeaTestRunner.java/ ) This makes it impossible to
start tests by using IntelliJ IDEA.
There is already an issue at JetBrains:
IDEA-127349 We can
revert the fix when this ticket is solved and most users are using an
IntelliJ version with the fix.