-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All binary artifacts should be reproducible #3690
Comments
@hboutemy Thanks for the report! What does it mean if diffoscope prints nothing for the |
@marcphilipp I manually redacted the content because it has no interest: module of course says fingerprints are different because junit-platform-commons-1.10.2.jar is different I don't dump full diffoscope outputs to reproducible central Git repo because it's would be too noisy |
|
redundant with the fact that the jar is different, then of course the fingerprint of the jar
sure, I could have kept that redundant info that does not cost much: you're the first one reviewing apart me, in general I do my choices for myself Do you want me to rebuild and add the content, so you'll see? |
@hboutemy I checked your rebuild of 5.11.0-M1 and it seems to have improved. However, running that locally I got more differences rather than fewer:
The differences in the *** central/org/junit/jupiter/junit-jupiter-api/5.11.0-M1/junit-jupiter-api-5.11.0-M1.module 2024-04-23 14:48:42.000000000 +0200
--- repository/org/junit/jupiter/junit-jupiter-api/5.11.0-M1/junit-jupiter-api-5.11.0-M1.module 2024-05-03 09:15:01.969563775 +0200
***************
*** 133,143 ****
{
"name": "junit-jupiter-api-5.11.0-M1-javadoc.jar",
"url": "junit-jupiter-api-5.11.0-M1-javadoc.jar",
! "size": 823145,
! "sha512": "e08f31d854e20c67819da8b4f2cd422ad9d0b54c3eddddba86b5e338c744a29cc4e2f57bcec6dba3985b258758974546f81121a443c8b0a6b087d5b99a28da43",
! "sha256": "08c31376acd48f0f5af759e877c325ae9db7243bb386afbb47eabd941af62fb5",
! "sha1": "7546d9d736df0c52dab962d893da8d83a3784cb5",
! "md5": "d34aba1365bb6f543d5946eadd0d89c9"
}
]
},
--- 133,143 ----
{
"name": "junit-jupiter-api-5.11.0-M1-javadoc.jar",
"url": "junit-jupiter-api-5.11.0-M1-javadoc.jar",
! "size": 823056,
! "sha512": "4cfb25d972c92349d7034eba189392caa83f3a48fdca28b08c61d3e884bb0c67124bbcb1b77f1e05df0f8fbd7c2dbadbba04bc38f033256d41d6a8466d2bffe1",
! "sha256": "9f4f7435e09dcd8f326271f15d0c2fc6e2e70f0ce1220a987c8d3e2edd644f39",
! "sha1": "3f34c9660abe7da8b1da4f359e90dc41ad30b58c",
! "md5": "b949d0d6b430274ab23232b409773c60"
}
]
}, @hboutemy The rebuild tool does not download and compare Javadoc JARs, right? I assume that's on purpose? If so, For my local rebuild of |
Should be resolved by f21a9c7 |
@hboutemy I checked your latest rebuild of 5.11.0-RC1. The only remaining differences are in I stand by what I said above:
I'm closing this issue since all other problems have been resolved and all binaries (except Javadoc JARs) where fully reproducible. |
Steps to reproduce
see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/junit/junit5/README.md
rebuild instructions are in the .buildspec
Context
work done after #3559 fixed most problems: thanks for the great work
Deliverables
The text was updated successfully, but these errors were encountered: