Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that Lifecycle.PER_CLASS implies @Execution(SAME_THREAD) in the JavaDoc #3849

Closed
hashhar opened this issue Jun 7, 2024 · 3 comments
Closed

Document that Lifecycle.PER_CLASS implies @Execution(SAME_THREAD) in the JavaDoc #3849

hashhar opened this issue Jun 7, 2024 · 3 comments
Assignees
@marcphilipp
Labels
component: Jupiter theme: documentation
Milestone
5.11 GA

Comments

@hashhar
Copy link

hashhar commented Jun 7, 2024 •
edited
Loading

The JUnit 5 User guide has this paragraph (https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-parallel-execution):

image

But this caveat doesn't seem to be mentioned at all in the JavaDocs for either @Execution or @TestInstance.
@hashhar
Copy link
Author

hashhar commented Jun 7, 2024

cc: @ssheikin

@sbrannen sbrannen added this to the 5.11 M3 milestone Jun 7, 2024
@sbrannen sbrannen changed the title Documentation about Lifecycle(PER_CLASS) implying Execution(SAME_THREAD) is not documented in the JavaDoc Document that Lifecycle(PER_CLASS) implyies Execution(SAME_THREAD) in the JavaDoc Jun 7, 2024
@sbrannen sbrannen changed the title Document that Lifecycle(PER_CLASS) implyies Execution(SAME_THREAD) in the JavaDoc Document that Lifecycle(PER_CLASS) implies Execution(SAME_THREAD) in the JavaDoc Jun 7, 2024
@sbrannen sbrannen changed the title Document that Lifecycle(PER_CLASS) implies Execution(SAME_THREAD) in the JavaDoc Document that Lifecycle.PER_CLASS implies @Execution(SAME_THREAD) in the JavaDoc Jun 7, 2024
@ssheikin ssheikin mentioned this issue Jun 18, 2024
Merged
vuriaval pushed a commit to vuriaval/junit5 that referenced this issue Jul 12, 2024
Document that Lifecycle.PER_CLASS implies @execution(SAME_THREAD) in …
7fbe0b2 
…the JavaDoc

Issue: junit-team#3849
@vuriaval vuriaval mentioned this issue Jul 12, 2024
Open
6 tasks
@marcphilipp marcphilipp modified the milestones: 5.11 RC1, 5.11 GA Jul 30, 2024
@marcphilipp marcphilipp self-assigned this Aug 11, 2024
@hashhar
Copy link
Author

hashhar commented Aug 12, 2024

Thank you @marcphilipp.

@marcphilipp
Copy link
Member

You're welcome! 🙂

@ssheikin ssheikin mentioned this issue Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: documentation
Projects
None yet
Milestone
5.11 GA
Development

No branches or pull requests
3 participants
@sbrannen @marcphilipp @hashhar