-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to let you know (not sure if it's intentional or not)
docker-stacks/mypy.ini
Line 11 in 5e1a27a
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slmg this is intentional and this doesn't have any effect on the images.
mypy.ini
is only used for checking our python files and we support>=3.9
(some devs might not have python 3.10 and it's not really worth it for our code to move to 3.10 at all).46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to trigger a new build with python-3.9? An unlucky timing made TensorFlow 2.8 available with python-3.10 only.
2022-05-29T17:23:10Z
jupyter/tensorflow-notebook:872b0256f345
jupyter/tensorflow-notebook:python-3.10.4
jupyter/tensorflow-notebook:tensorflow-2.8.1
2022-05-28T16:07:09Z
jupyter/tensorflow-notebook:872b0256f345
jupyter/tensorflow-notebook:python-3.9.13
jupyter/tensorflow-notebook:tensorflow-2.6.2
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering my own question. I can see there is no easy way to do this in the current workflow.
inputs
would need to be defined on theworkflow_dispatch
event.docker-stacks/.github/workflows/docker.yml
Line 44 in 5e1a27a
Triggering a workflow with python version as an arg would however make images tags collide. How about supporting python 3.9 alongside python 3.10 instead? Kinda blue-green deployment, it would ensure a smoother transition between two major envs.
Happy to create a feature request if you deem it's reasonable.
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About tags collision, I just realized
jupyter/tensorflow-notebook:872b0256f345
exists for both pyhon-3.10 and the latest python-3.9, as shown in my first comment. 👀46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slmg I think right now it's impossible to have many python versions simultaneously.
Our pipeline is one threaded and it takes so much time already.
And it also uses images from dockerhub instead of freshly built ones (it's so bad, but we will fix it).
And this is also the reason for the tag collision.
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathbunnyru, yes I could see you're in the middle of a big refactor of the workflows.:superhero:
No worries I'll adapt to this new world via the addition of a python 3.9 kernel then.
Thanks again for the good work on this repo!
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are forced to go down that route as well. Could anyone share their experience or steps to make this happen? Thanks!
46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jakob-keller , because I use certain Jupyter extensions not yet supporting python-3.10, I ended up using the latest available python-3.9 image instead, and installed a pytthon-3.10 kernel side-by-side to transition peacefully. The process would be almost identical if you'd rather have the
base
env running on 3.10 and an additional 3.9 kernel though.46c4128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your thorough response. Python 3.10 is not yet a requirement for us and I am now also pinning the last available Python 3.9 based image.