Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[tune] implicit-anchor optimization" #114

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Revert "[tune] implicit-anchor optimization" #114

merged 1 commit into from
Jan 24, 2019

Conversation

k-takata
Copy link
Owner

This reverts commit 282338f.
It seems that the commit didn't improve the performance.
Revert it to fix #100.

This reverts commit 282338f.
It seems that the commit didn't improve the performance.
Revert it to fix #100.
@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #114 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   82.93%   83.22%   +0.29%     
==========================================
  Files          62       62              
  Lines       12795    12795              
==========================================
+ Hits        10611    10649      +38     
+ Misses       2184     2146      -38
Impacted Files Coverage Δ
regcomp.c 92.21% <100%> (ø) ⬆️
regexec.c 91.13% <0%> (+0.06%) ⬆️
enc/gb18030.c 13.68% <0%> (+6.31%) ⬆️
enc/euc_tw.c 39.39% <0%> (+9.09%) ⬆️
enc/euc_kr.c 70.37% <0%> (+33.33%) ⬆️
enc/big5.c 69.44% <0%> (+36.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff464e9...cef834c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.343% when pulling cef834c on fix-100 into ff464e9 on master.

@k-takata k-takata merged commit cf3bc70 into master Jan 24, 2019
@k-takata k-takata deleted the fix-100 branch January 24, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance regression if quantifier lower bound is 1
3 participants