Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multus-thick] Suppress error in case of no connection to server #1080

Closed
s1061123 opened this issue Apr 26, 2023 · 0 comments · Fixed by #1084
Closed

[multus-thick] Suppress error in case of no connection to server #1080

s1061123 opened this issue Apr 26, 2023 · 0 comments · Fixed by #1084

Comments

@s1061123
Copy link
Member

What happend:
Multus thick case, multus-shim may send error message for DEL in CNI reply when mutlus-shim cannot connect to server. To following CNI spec, DEL command should not return error.

What you expected to happen:
It should be no error in CNI result.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Multus version
    image path and image ID (from 'docker images')
  • Kubernetes version (use kubectl version):
  • Primary CNI for Kubernetes cluster:
  • OS (e.g. from /etc/os-release):
  • File of '/etc/cni/net.d/'
  • File of '/etc/cni/multus/net.d'
  • NetworkAttachment info (use kubectl get net-attach-def -o yaml)
  • Target pod yaml info (with annotation, use kubectl get pod <podname> -o yaml)
  • Other log outputs (if you use multus logging)
s1061123 added a commit to s1061123/multus-cni that referenced this issue May 1, 2023
This fix suppress error message in thick plugin's shim, for
DEL command, to align with CNI spec.

Fix k8snetworkplumbingwg#1080
s1061123 added a commit to s1061123/multus-cni that referenced this issue May 2, 2023
This fix suppress error message in thick plugin's shim, for
DEL command, to align with CNI spec.

Fix k8snetworkplumbingwg#1080
s1061123 added a commit to s1061123/multus-cni that referenced this issue May 2, 2023
This fix suppress error message in thick plugin's shim, for
DEL command, to align with CNI spec.

Fix k8snetworkplumbingwg#1080
s1061123 added a commit to s1061123/multus-cni that referenced this issue May 2, 2023
This fix suppress error message in thick plugin's shim, for
DEL command, to align with CNI spec.

Fix k8snetworkplumbingwg#1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant