Removes command line arguments in favor of configMap/JSON config #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbtv
changed the title
|
Changes unknown |
dougbtv
force-pushed
the
multus40-prefer-configmap
branch
from
e280323
to
8884d1c
Compare
dougbtv
force-pushed
the
multus40-prefer-configmap
branch
from
8884d1c
to
664a068
Compare
dougbtv
changed the title
|
This should be essentially ready to review and ready to roll |
Merged
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for making so that users only have to specify configurations in a single place -- the configMap.
Keeps only the bare minimum of command line options (in particular: where the config file lives, and the version flag)
Currently just attempts to remove command line arguments and see what needs to change from there (before further changes)