Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use *[]net.IP for 'default-route' network selection element. #864

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented Jun 16, 2022

Allows for empty default route for IPv6, e.g. to select the default-route for a given interface but to pass an empty list.

@s1061123 s1061123 requested a review from dougbtv June 16, 2022 12:15
@coveralls
Copy link

coveralls commented Jun 16, 2022

Coverage Status

Coverage increased (+0.08%) to 70.329% when pulling 107624c on s1061123:default-route-pointer into 13eb83a on k8snetworkplumbingwg:master.

pkg/multus/multus_test.go Show resolved Hide resolved
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description to this PR so people can understand what this is fixing, and why that is important ?

@maiqueb
Copy link
Collaborator

maiqueb commented Jun 21, 2022

Can you add a description to this PR so people can understand what this is fixing, and why that is important ?

@s1061123 / @dougbtv ^

@s1061123 s1061123 force-pushed the default-route-pointer branch 2 times, most recently from 5fb1b2c to 894fa10 Compare June 21, 2022 17:05
@dougbtv dougbtv merged commit ca8c9c5 into k8snetworkplumbingwg:master Jun 21, 2022
@s1061123 s1061123 deleted the default-route-pointer branch June 22, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants