Support for HostIFName in DeviceInfo and vfid in PciDevice #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1061123 These two pr's allow CNI to implement a flexible deviceinfo. |
|
This repository just implements https://github.com/k8snetworkplumbingwg/device-info-spec so we don't additional feature in it without any specification change. To modify this specification, please bring the topic in network plumbing working group meeting. This meeeting is bi-weekly, so next meeting will be May 30th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.The addition of these two fields is mainly to adapt to the deviceinfo of more types of network cards, such as veth in Calico and ovs-cni. Among them, ovs-cni has a greater need for this field. It relies on delivering flow tables under the vethName on the host to divert traffic. Adding this field can bind the vethName on the host with the corresponding Pod, eliminating the need to store the mapping between ovs and Pod in a separate database. I will adapt this content in a subsequent ovs-cni PR.
2.In metric monitoring, more information about the VF network card is needed, such as vfid and OrigVfName. I will later add OrigVfName to HostIFName and vfid to vfid in sriov-cni to facilitate reading the Pod's VfName and vfid.