fix getUserScores nullpointer

kane50613 · Jun 13, 2021 · fadc92a · fadc92a
1 parent cc05855
commit fadc92a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 26 deletions.
diff --git a/dependency-reduced-pom.xml b/dependency-reduced-pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>tw.kane</groupId>
   <artifactId>osu4j</artifactId>
-  <version>v2.3</version>
+  <version>v2.3.1</version>
   <build>
     <plugins>
       <plugin>
@@ -18,17 +18,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <artifactId>maven-jar-plugin</artifactId>
-        <configuration>
-          <archive>
-            <manifest>
-              <addClasspath>true</addClasspath>
-              <mainClass>tw.kane.osu4j.Osu</mainClass>
-            </manifest>
-          </archive>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
   <distributionManagement>

diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>tw.kane</groupId>
     <artifactId>osu4j</artifactId>
-    <version>v2.3.1</version>
+    <version>v2.3.2</version>
 
     <distributionManagement>
         <repository>
@@ -31,18 +31,6 @@
                     </execution>
                 </executions>
             </plugin>
-<!--            <plugin>-->
-<!--                <groupId>org.apache.maven.plugins</groupId>-->
-<!--                <artifactId>maven-jar-plugin</artifactId>-->
-<!--                    <configuration>-->
-<!--                    <archive>-->
-<!--                        <manifest>-->
-<!--                            <addClasspath>true</addClasspath>-->
-<!--                            <mainClass>tw.kane.osu4j.Osu</mainClass>-->
-<!--                        </manifest>-->
-<!--                    </archive>-->
-<!--                </configuration>-->
-<!--            </plugin>-->
         </plugins>
     </build>
 

diff --git a/src/main/java/tw/kane/osu4j/OsuClient.java b/src/main/java/tw/kane/osu4j/OsuClient.java
@@ -85,7 +85,7 @@ public Score[] getUserScores(String id, ScoreType type, boolean includeFails, Mo
             }
             return scores.toArray(new Score[0]);
         }
-        return null;
+        throw new NotFoundException();
     }
 
     public Beatmap getBeatmap(String id) throws IOException, InvalidTokenException, NotFoundException {