Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix collapseWhitespace for <output> tag #1071

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

epexa
Copy link

@epexa epexa commented Aug 10, 2020

Fixes #1070

@DanielRuf
Copy link

Awesome. Can you provide a PR for this at https://github.com/DanielRuf/html-minifier-terser? That would be really great.

@DanielRuf
Copy link

Also I think it makes sense to add some test for this. Can you give this a try or do you need help with this?

@XhmikosR
Copy link
Collaborator

XhmikosR commented Oct 8, 2021

@epexa yeah, see if you can add a test case please.

@kangax @DanielRuf might be worth joining forces in one repo. I personally do use terser for my JS files, but worst case we could make the JS minifier configurable?

@DanielRuf
Copy link

@kangax @DanielRuf might be worth joining forces in one repo.

Sounds definitely good. But personally I have minimized the time that I invest in opensource and I have onboarded two new maintainers from tje JS and webpack community (see terser/html-minifier-terser#79). To be honest, I'm struggling with depressions and somewhat feel burned out. So please do not expect too much from my side for now.

In general it would be probably better to ask the new maintainers and I can try to do some reviews or express my opinion in some cases.

Joining forces, bringing html-minifier forward and work together instead of against each other would be ideal in the opensource community and something that I have always tried in other projects in the past (for https://github.com/materializecss/materialize I invited the original maintainers but unfortunately they never accepted the invitations, but also life is more important probably).

I've chosen the terser community as new home since I thought this would be a good place and I've learned from other projects that there are many problems when the owner is not an org but a normal user (I have worked on projects where the owners left this world and there were no more changes done), especially regarding the bus / truck factor and other things. I'm open to share projects and invite others like I did with https://github.com/website-checks/website-checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapseWhitespace remove the space around the <output> tag
3 participants