Added in copy button

[Yash-Singh1]

Overview

Added in a button called Copy Result with an ID of copy-btn allowing you to copy the result of the minification process.

List of Updates

Here is a list of the updates:

• Added in a button inside index.html with the same CSS as the earlier minify-btn
• Enabled the copy-btn on click of the minify-btn
• Copied the result on click of the copy-btn

Testing

To test my changes inside a development environment, go to: https://yash-singh1.github.io/html-minifier/

[Yash-Singh1]

Any updates on this pull request, or is it good to go?

[DanielRuf]

LGTM

[Yash-Singh1]

So, will @kangax merge it?

[kangax]

hm, Travis CI doesn't let me merge, says some checks haven't completed yet

[Yash-Singh1]

@kangax Looks like it says that here too:

Look at this:
https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154
I think it is a fix. Looks like this was an issue: travis-ci/travis-ci#10187
Here is another write-up someone wrote on the fix: travis-ci/travis-ci#10204
I think the solution is just to make sure that you have access to merge this pull request even when the tests haven't passed. This should be enabled in scenarios in which you want to force merge. I ran the tests manually, here is what appeared:

If you want a close up of the results:

Looks like all the tests worked manually. 👍

[Yash-Singh1]

Since html-minifier now uses Gh Actions, can this be merged?

[kangax]

yeah, I'm ok with it

@XhmikosR any objections?

[XhmikosR]

Yeah, this shouldn't land as is. innerHTML is meaningless when we only need to change the text.

Also, I believe we should keep the initial text instead of re-adding it.

[DanielRuf]

Yeah, this shouldn't land as is. innerHTML is meaningless when we only need to change the text.

You are right, innerText should be sufficient then.