fix config file: "html5" and "includeAutoGeneratedTags" were ignored #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the fix for kangax#860 enabled disabling these 2 flags from the command line but also made them uncontrollable from the JSON config file old commander.js (not 2021 commander.js) assigns boolean true unconditionally as defaultValue for all --no- arguments, when minifier fuses command line and JSON config file options together in cli.js's createOptions(), it sees program["includeAutoGeneratedTags"] = true and ignored config["includeAutoGeneratedTags"], in my case "= false". Delete the defaultValue/key from commander.js object before parsing user's ARGV to solve the bug.
|
Would be great to have this PR at https://github.com/terser/html-minifier-terser too =) |
|
@bulk88 does this apply to the latest commander too? I'm wondering because the plan is to update all deps to the latest version. |
|
I don't know. commander module from 10 years ago and 2021 commander module have almost no source code in common by now when I debugged this/wrote the patch and there was no attempt at back (bug) compat by commander's authors IIRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix for #860 enabled disabling these 2 flags from the command line
but also made them uncontrollable from the JSON config file
old commander.js (not 2021 commander.js) assigns boolean true
unconditionally as defaultValue for all --no- arguments, when minifier
fuses command line and JSON config file options together in cli.js's
createOptions(), it sees program["includeAutoGeneratedTags"] = true and
ignored config["includeAutoGeneratedTags"], in my case "= false". Delete
the defaultValue/key from commander.js object before parsing user's ARGV
to solve the bug.
EXTRA NOTES this probably fixes #1045
work around for old/publish html-minifiers is to always put
--no-include-auto-generated-tagson cmd line in addition to"includeAutoGeneratedTags": falsein json config file