Fix/update benchmark #1109
Draft
Fix/update benchmark #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Oct 2, 2021
benchmark.js
Outdated
| @@ -254,7 +254,7 @@ run(fileNames.map(function(fileName) { | |||
| // Apply Brotli on minified output | |||
| function(done) { | |||
| readBuffer(info.filePath, function(data) { | |||
| var output = new Buffer(brotli.compress(data, true).buffer); | |||
| var output = Buffer.from(brotli.compress(data, true).buffer); | |||
There was a problem hiding this comment.
Not sure if .buffer is needed anymore
XhmikosR
force-pushed
the
benchmark
branch
2 times, most recently
from
e8efec9
to
4dcff16
Compare
XhmikosR
commented
Oct 10, 2021
| .on('finish', callback); | ||
| } | ||
|
|
||
| function brotli(inPath, outPath, callback) { |
There was a problem hiding this comment.
This is the same as the gzip function except for the method name. If someone wants to deduplicate this more please go ahead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htmlcompressor.comhas an upper limit of ~300KB hence why it fails. We could probably just drop it later.Also, IMHO we should move the benchmark script into the benchmark folder along with its own package.json and run it on CI (probably with a cron job since we don't want it to run all the time). Otherwise it can break at any time again.