Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve whitespace around inline <ruby> #905

Merged
merged 1 commit into from
Apr 7, 2018
Merged

Conversation

YodasWs
Copy link
Contributor

@YodasWs YodasWs commented Apr 7, 2018

also:

  • Preserve whitespace inside <rp> tag (to buffer parentheses for very old browsers)
  • Preserve whitespace around inline <rtc> tags
  • Mark <rb> as valid HTML

for #904

Copy link
Collaborator

@alexlamsl alexlamsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test changes are good to go.

.gitignore Outdated
@@ -7,3 +7,5 @@
/benchmarks/generated
/node_modules/
/npm-debug.log
*.swp
*~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this out of the PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind - I have performed the edit.

also:
* Preserve whitespace inside <rp> tag (to buffer parentheses for very
old browsers)
* Preserve whitespace around inline <rtc> tags
* Mark <rb> as valid HTML
@alexlamsl
Copy link
Collaborator

Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants