Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit nomodule attribute value as it's boolean #966

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented Sep 25, 2018

Before

const {minify} = require('html-minifier');

minify('<script nomodule="nomodule"></script>', {collapseBooleanAttributes: true});
//=> '<script nomodule="nomodule"></script>'

After

const {minify} = require('html-minifier');

minify('<script nomodule="nomodule"></script>', {collapseBooleanAttributes: true});
//=> '<script nomodule></script>'

ref. specification of nomodule attribute: https://html.spec.whatwg.org/multipage/scripting.html#attr-script-nomodule

@shinnn
Copy link
Contributor Author

shinnn commented Dec 17, 2018

Could anyone review this?

@alexlamsl
Copy link
Collaborator

alexlamsl commented Mar 22, 2019

Please add a test case (around here) to make sure your change is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants