Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show help if no arguments supplied #985

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

jamesgeorge007
Copy link

@jamesgeorge007 jamesgeorge007 commented Dec 28, 2018

Presently if the user fires in html-minifier without supplying any of the options, nothing is gonna happen. It is good to have the help showing up in that case 🤔

@DamonHD
Copy link

DamonHD commented Dec 28, 2018

I counter-suggest that plenty of well-understood applications designed to work in a pipeline behave exactly like that and for good reason, all the way up from the humble cat, sed, awk, grep, etc... And this is in many ways a glorified filter too.

Rgds

Damon

@jamesgeorge007
Copy link
Author

jamesgeorge007 commented Dec 28, 2018

I think it is a good idea to have this since the user would get an idea of the various commands available for the very first time 🤔

@DamonHD
Copy link

DamonHD commented Dec 28, 2018

It's fairly well understood that if a (filter) command is silent with no args then you try it with -help or --help. Else every single time you use it as a filter you need to add arguments and clutter to suppress that (unwanted) output.

For non-filter-pipeline commands your case is stronger.

Rgds

Damon

@jamesgeorge007
Copy link
Author

@DamonHD Most of the CLI tools these days ship with this option. I guess it is good to have despite the thoughts above 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants